Modify LED error sequence to be more recognisable #4920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current error sequence for microcontrollers with less than 4 LEDs is to toggle an LED at a fixed rate. Change the sequence to 4 short pulses followed by 4 long pulses.
- Removed the patterned LED sequence, all boards now use the 4 fast pulse, 4 slow pulses LED sequence. - Changed the LED used from LED_RED to LED1. Only 58/174 targets seem to define LED_RED but they all define LED1. - Removed all ERROR_RED and ERROR_PATTERN definitions from targets/targets.json
0xc0170
approved these changes
Aug 16, 2017
theotherjimmy
approved these changes
Aug 16, 2017
|
/morph test |
|
/morph echo |
1 similar comment
|
/morph echo |
|
I recieved your comment! Here's what you wrote!
|
|
/morph test |
1 similar comment
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@deepikabhavnani @c1728p9 @bulislaw Happy with unifying the LED sequence? |
bulislaw
approved these changes
Aug 22, 2017
deepikabhavnani
approved these changes
Aug 22, 2017
|
Woohoo :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening this PR from the previous PR. I accidentally closed the previous one.
Unified the LED error sequence for all boards. Previously the LED sequence for boards with 4 LEDs was a patterned sequence, and for other boards, a fixed blinking LED. The new sequence is a repeating sequence of 4 fast pulses, followed by 4 slow pulses.
Fixes #1295 LED error patterns