Increase default PPP stack size from 512 bytes to 768 bytes. #4677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
approved these changes
Jun 30, 2017
0xc0170
approved these changes
Jun 30, 2017
|
Not really related to this PR, but we should have documentation somewhere stating how different features will impact memory usage/requirements. |
|
@RobMeades Can you please amend your commit to provide more details (what you already did in the description here) - why are we changing from x to y stack value. |
PPP is running close to the edge of its default thread stack size of 512 bytes. When it experiences an FCS error on the incoming data (for example. caused by character loss when the incoming serial rate is too high for it to process in time) it performs some additional work which overruns the thread's stack, hitting the OS "stack underflow" check. Increasing the PPP stack size to 768 bytes resolves this problem.
484ad32 to
921d1fa
Compare
|
Certainly, done. |
|
retest uvisor |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PPP is running close to the edge of its default thread stack size of 512 bytes. When it experiences an FCS error on the incoming data (caused by character loss when the incoming serial rate is too high for it to process in time) it performs some additional work which overruns the thread's stack, hitting the OS "stack underflow" check.
Increasing the PPP stack size to 768 bytes resolves this problem.
Note: this change already discussed at some length with @kjbracey-arm.
Steps to reproduce
Run
PPPCellularInterfacewith the UART serial port running at 460800 or higher and wait for the OS stack check to be hit.