DISCO_L475VG_IOT01A : Add new target #4242

bcostm · 2017-04-28T09:26:57Z

Description

This PR adds the new B-L475E-IOT01A board.

Status

READY

Migrations

NO

0xc0170 · 2017-04-28T14:52:23Z

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L475xG/device/TOOLCHAIN_IAR/stm32l475xx.icf

+/* [RAM = 128kb = 96kb + 32kb = 0x20000] */
+/* Vector table dynamic copy: Total: 98 vectors = 392 bytes (0x188) to be reserved in RAM */
+define symbol __NVIC_start__          = 0x10000000;
+define symbol __NVIC_end__            = 0x10000187; /* Aligned on 8 bytes (392 = 49 x 8) */


Should be aligned as the comment says? Or that one is related to SRAM2 start that is then?

Yes this is already aligned (must be blocks of 8 bytes). This is the same on other L4xx devices.

Could we change that comment to say that the address after the end is 8 byte aligned? I don't think that 0x187 is a multiple of 8 bytes.

adbridge · 2017-05-04T14:34:40Z

Oulu CI failed with:
Couldn't allocate resources

Restarted....

bcostm · 2017-05-09T11:27:06Z

Rebased + solved conflicts

0xc0170 · 2017-05-11T12:57:15Z

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L475xG/device/TOOLCHAIN_IAR/stm32l475xx.icf

+define region SRAM1_region = mem:[from __region_SRAM1_start__ to __region_SRAM1_end__];
+
+/* Stack 1/8 and Heap 1/4 of RAM */
+define symbol __size_cstack__ = 0x8000;


Is this not too big for mbed OS - this is isr stack ?

Yes maybe. I kept the same values as those used in L476 targets.

0xc0170 · 2017-05-11T13:12:38Z

tools/build_travis.py

@@ -84,6 +84,8 @@
    { "target": "DISCO_F469NI",      "toolchains": "GCC_ARM", "libs": ["dsp", "rtos"] },
    { "target": "DISCO_F746NG",      "toolchains": "GCC_ARM", "libs": ["dsp"] },
    { "target": "DISCO_F769NI",      "toolchains": "GCC_ARM", "libs": ["dsp", "rtos"] },
+    { "target": "DISCO_L475VG_IOT01A", "toolchains": "GCC_ARM", "libs": ["dsp", "rtos", "usb"] },


Can you please remove rtos from here (cmsis5 will make this deprecated soon)

0xc0170 · 2017-05-11T13:12:44Z

tools/build_travis.py

+    {"target": "DISCO_L475VG_IOT01A",
+     "toolchains": "GCC_ARM",
+     "tests": {""     : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"],
+               "rtos" : ["RTOS_1", "RTOS_2", "RTOS_3"],


bcostm · 2017-05-15T09:09:26Z

Rebased + removed rtos in build_travis.py

0xc0170 · 2017-05-15T15:08:29Z

Can you please rebase again, There was one merge earlier to result in conflicts ( this is probably because of cmsis5 update) as reported earlier

bcostm · 2017-05-16T14:53:47Z

Rebased

theotherjimmy · 2017-05-16T14:54:52Z

/morph test

mbed-bot · 2017-05-17T04:02:36Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 237

All builds and test passed!

0xc0170 · 2017-05-17T09:26:43Z

Note: this might require one more rebase, as cmsis5 update is going to land soon. It touches tools script, and might require additional update for the new rtos, we will keep you informed and provide an assistance to make it forward. Thank you for understanding

bcostm · 2017-05-18T09:26:48Z

OK. So I wait the merge of CMSIS5 update and I will rebase after.

bcostm · 2017-05-30T07:26:19Z

cmsis5 update is going to land soon

Any idea when ?

It becomes critical for us. Can we merge this PR first ?

0xc0170 · 2017-05-30T08:10:15Z

Any idea when ?

Should have been. There's one last module to be updated, our tests should be fixed by then and get a green light.

It becomes critical for us. Can we merge this PR first ?

We would like to, however constant rebasing (too many changes ongoing) and restarting tests are prolonging this update. We will have a look at new targets today, and cmsis5, I'll keep you updated. Thanks for understanding.

… .icf file

bcostm · 2017-06-12T15:14:59Z

Rebased and solve build issue related to recent other PRs merges.

0xc0170 · 2017-06-15T12:30:16Z

An update: We will run CI for this as soon as the upcoming release is made (CI queued up with jobs for it).

screamerbg · 2017-06-15T12:34:59Z

@0xc0170 does this mean that this PR will be included in the release as well or?

0xc0170 · 2017-06-15T13:06:39Z

Shall get in for 5.5.1 (the next week), I added a label.

sg- · 2017-06-15T16:28:43Z

/morph test

mbed-bot · 2017-06-16T00:30:15Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 563

Test Prep failed!

adbridge · 2017-06-16T09:33:36Z

Looks like one of the test nodes lost communication with github:

19:19:18  > git checkout -f 226af545a41df30f1846f4da3eb700eea7ed29ec
19:29:18 ERROR: Timeout after 10 minutes
19:29:35 FATAL: Could not checkout 226af545a41df30f1846f4da3eb700eea7ed29ec
19:29:50 hudson.plugins.git.GitException: Command "git checkout -f 226af545a41df30f1846f4da3eb700eea7ed29ec" returned status code -1:

We can just restart this once rc3 is green

0xc0170 · 2017-06-17T11:31:02Z

/morph test

mbed-bot · 2017-06-17T20:46:37Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 579

Test failed!

0xc0170 · 2017-06-19T08:08:56Z

The failures are not related to this patch, neither the failures reappearing

/morph test

mbed-bot · 2017-06-19T15:03:56Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 584

Example Build failed!

0xc0170 · 2017-06-19T15:10:47Z

Job aborted ,will be restarted

theotherjimmy · 2017-06-19T23:09:17Z

/morph test

mbed-bot · 2017-06-20T01:08:27Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 589

Example Build failed!

studavekar · 2017-06-20T04:53:55Z

/morph test

mbed-bot · 2017-06-20T06:36:33Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 590

All builds and test passed!

0xc0170 added the needs: review label Apr 28, 2017

0xc0170 reviewed Apr 28, 2017

View reviewed changes

bcostm mentioned this pull request May 3, 2017

When is support for STM32L475 IOT node planned? #4228

Closed

bcostm force-pushed the dev_disco-l475-iot branch from 5c232ee to b45e88d Compare May 9, 2017 11:25

0xc0170 reviewed May 11, 2017

View reviewed changes

bcostm force-pushed the dev_disco-l475-iot branch from b45e88d to 2954449 Compare May 15, 2017 09:06

0xc0170 approved these changes May 15, 2017

View reviewed changes

0xc0170 added ready for merge scope: new-target and removed needs: review labels May 15, 2017

0xc0170 added needs: work and removed ready for merge labels May 15, 2017

bcostm force-pushed the dev_disco-l475-iot branch from 2954449 to 1898b1f Compare May 16, 2017 14:52

0xc0170 added ready for merge and removed needs: work labels May 17, 2017

0xc0170 added needs: status update and removed ready for merge labels May 18, 2017

sg- added the needs: CI label Jun 3, 2017

bcostm added 6 commits June 12, 2017 17:03

DISCO_L475VG_IOT01A: change comment for 8-byte aligned adress for IAR…

2ed207e

… .icf file

DISCO_L475VG_IOT01A: remove rtos from build_travis.py

59bfa39

DISCO_L475VG_IOT01A: Add generic buttons declaration

3519d53

DISCO_L475VG_IOT01A: Move USB device config files

f6a4883

DISCO_L475VG_IOT01A: Update cmsis_nvic files

af2078f

DISCO_L475VG_IOT01A: Update device files after CubeL4 update

66cbc8b

bcostm force-pushed the dev_disco-l475-iot branch from 2be7918 to 66cbc8b Compare June 12, 2017 15:03

DISCO_L475VG_IOT01A: Add include of LL timer file

8ede14d

0xc0170 added the release-version: 5.5.1 label Jun 15, 2017

0xc0170 added ready for merge and removed needs: CI labels Jun 20, 2017

adbridge merged commit c5e1fa7 into ARMmbed:master Jun 20, 2017

sg- removed the ready for merge label Jun 20, 2017

bcostm deleted the dev_disco-l475-iot branch June 28, 2017 12:41

DISCO_L475VG_IOT01A : Add new target #4242

DISCO_L475VG_IOT01A : Add new target #4242

Uh oh!

Conversation

bcostm commented Apr 28, 2017

Description

Status

Migrations

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adbridge commented May 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcostm commented May 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bcostm commented May 15, 2017

Uh oh!

0xc0170 commented May 15, 2017

Uh oh!

bcostm commented May 16, 2017

Uh oh!

theotherjimmy commented May 16, 2017

Uh oh!

mbed-bot commented May 17, 2017

Output

Uh oh!

0xc0170 commented May 17, 2017

Uh oh!

bcostm commented May 18, 2017

Uh oh!

bcostm commented May 30, 2017

Uh oh!

0xc0170 commented May 30, 2017

Uh oh!

bcostm commented Jun 12, 2017

Uh oh!

0xc0170 commented Jun 15, 2017

Uh oh!

screamerbg commented Jun 15, 2017

Uh oh!

0xc0170 commented Jun 15, 2017

Uh oh!

sg- commented Jun 15, 2017

Uh oh!

mbed-bot commented Jun 16, 2017

Output

Uh oh!

adbridge commented Jun 16, 2017

Uh oh!

0xc0170 commented Jun 17, 2017

Uh oh!

mbed-bot commented Jun 17, 2017

Output

Uh oh!

0xc0170 commented Jun 19, 2017

Uh oh!

mbed-bot commented Jun 19, 2017

Output

Uh oh!

0xc0170 commented Jun 19, 2017

Uh oh!

adbridge commented May 4, 2017 •

edited

Loading