-
Notifications
You must be signed in to change notification settings - Fork 3k
Move config system into it's own folder and refactor header generation #4150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move config system into it's own folder and refactor header generation #4150
Conversation
b332395
to
be6c58f
Compare
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
morph test - known failure, will be fixed soon (patch already proposed, waiting for CI to complete) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just 2 small things in the template. Tools are slowly becoming more organized 👍
@@ -0,0 +1,26 @@ | |||
// Automatically generated configuration file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file contain license header? I would say yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also say yes. now it has one.
{%- endif %} | ||
{% endfor %} | ||
{%- endif %} | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have a new line at the end of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
be6c58f
to
6e556e4
Compare
@0xc0170 The gig's up! you noticed that I was organizing the tools. |
Thanks for the review. I addressed all of the comments, so I'm moving this to needs Review and needs CI |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputExample Build failed! |
Something wrong with armcc failing:
gcc:
|
@tommikas Thanks for the info. I'll check into the failure. |
I also broke the config header template into it's own file. Further, I fixed a bug in the config header generation where if no macros, builds would crash.
6e556e4
to
1570233
Compare
That should do it. I was using name included the value... |
/morph test |
1 similar comment
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Descritpion
The config system is a huge file, and seems to be growing to support
things such as bootloader. This implies that the Config class may grow
to beyond the size of this one file.
Furthermore, I saw an error generated by the online build system recently.
This was the traceback:
How to reproduce
Simply create an
mbed_app.json
that removes all macros. This willcause the macros array to be empty without causing a
ConfigException
.When the macros array is empty,
max()
becomes very confused, as itis asked to take the maximum of an empty array.
New behavior
We just add a
[0]
to the end to prevent that silly traceback.