Modify semihost_disabledebug() to support more interface FW revs #4101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of semihost_disabledebug() hangs when used with mbed interface firwmare revision 21164, the first version which added support for this semihost call. I encountered this hang when running a Release build on my mbed-LPC1768 board as the RTOS attempted to disable the debugger before the idle thread put the CPU to sleep. The 21164 interface firmware expects that R1 points to a valid argument block but the current implementation passes in NULL. The fix was to pass in a dummy block which is ignored by the newer 141212 revision of the firmware and allows the 21164 version to proceeed without halting the CPU until a manual reset. Before this fix semihost_disabledebug() did work with the latest mbed interface firmware revision 141212 but I rarely use this revision of the interface firmware due to the instability issues I have encountered in the past with its CDC and LocalFileSystem functionality. With this proposed fix, the code now works with both the 21164 and 141212 revisions of the mbed interface firmware on the mbed-LPC1768.
0xc0170
approved these changes
Apr 3, 2017
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of semihost_disabledebug() hangs when used
with mbed interface firwmare revision 21164, the first version which
added support for this semihost call. I encountered this hang when
running a Release build on my mbed-LPC1768 board as the RTOS attempted
to disable the debugger before the idle thread put the CPU to sleep.
The 21164 interface firmware expects that R1 points to a valid argument
block but the current implementation passes in NULL. The fix was to
pass in a dummy block which is ignored by the newer 141212 revision of
the firmware and allows the 21164 version to proceeed without halting
the CPU until a manual reset.
Before this fix semihost_disabledebug() did work with the latest
mbed interface firmware revision 141212 but I rarely use this revision
of the interface firmware due to the instability issues I have
encountered in the past with its CDC and LocalFileSystem functionality.
With this proposed fix, the code now works with both the 21164 and
141212 revisions of the mbed interface firmware on the mbed-LPC1768.