Fixed OBOE in async serial tx for NRF52 target, fixes #4002 #4003
Conversation
|
@anangl @nvlsianpu - please review |
|
Yes, shame on me, definitely. I've introduced this obvious bug when adding waiting for TX completion. And it appears that I haven't even run my test app after making these changes. Well, I have to live with it... Anyway, thanks a lot for spotting and fixing it. |
|
@anangl CI tests shield results with this type of changes ! :-) Thanks for the review |
|
/morph test |
|
Does ci/morph-test run the tests on actual embedded devices? If so, how do you write tests for it? Does it automatically pick up on Greentea test suites? |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Any idea when this can get merged? |
|
@seppestas there are a few test plans (test vs. test-nightly vs export-build) and these kick off different classes of tests but yes, in one way or another nearly all tests that land to master are able to be added to the test plans |
|
Also, would you mind signing the https://developer.mbed.org/contributor_agreement/ |
|
@sg- done. |
Ports for Upcoming Targets 3841: Add nRf52840 target ARMmbed/mbed-os#3841 3992: Introducing UBLOX_C030 platform. ARMmbed/mbed-os#3992 Fixes and Changes 3951: [NUCLEO_F303ZE] Correct ARDUINO pin ARMmbed/mbed-os#3951 4021: Fixing a macro to detect when RTOS was in use for the NRF52840_DK ARMmbed/mbed-os#4021 3979: KW24D: Add missing SPI defines and Arduino connector definitions ARMmbed/mbed-os#3979 3990: UBLOX_C027: construct a ticker-based wait, rather than calling wait_ms(), in the ARMmbed/mbed-os#3990 4003: Fixed OBOE in async serial tx for NRF52 target, fixes #4002 ARMmbed/mbed-os#4003 4012: STM32: Correct I2C master error handling ARMmbed/mbed-os#4012 4020: NUCLEO_L011K4 remove unsupported tool chain files ARMmbed/mbed-os#4020 4065: K66F: Move bss section to m_data_2 Section ARMmbed/mbed-os#4065 4014: Issue 3763: Reduce heap allocation in the GCC linker file ARMmbed/mbed-os#4014 4030: [STM32L0] reduce IAR heap and stack size for small targets ARMmbed/mbed-os#4030 4109: NUCLEO_L476RG : minor serial pin update ARMmbed/mbed-os#4109 3982: Ticker - kl25z bugfix for handling events in the past ARMmbed/mbed-os#3982
Description
This fixes an off-by-one error in the async serial write code for the NRF5 target.
Status
READY
Migrations
User should make sure to remove any workarounds they might have added to circumvent this issue.
Steps to test or reproduce
See #4002.