CMake: Set TARGET_NAME macro #15041
Merged
CMake: Set TARGET_NAME macro #15041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromecoutant
approved these changes
Sep 1, 2021
|
@LDong-Arm, thank you for your changes. |
0xc0170
previously approved these changes
Sep 1, 2021
|
Please rebase to the latest master to get github workflow update to fix basic checks |
The C/C++ macro `TARGET_NAME` allows code to print the current target's name, e.g. in error reporting when a fault happens. This macro is exported by Mbed CLI 1 and used by mbed_error.c, so for compatibility we let CMake set the same name of macro. Fixes ARMmbed/mbed-tools#313
b856447 to
aca2d63
Compare
Pull request has been modified.
|
Rebased |
0xc0170
approved these changes
Sep 1, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The C/C++ macro
TARGET_NAMEallows code to print the current target's name, e.g. in error reporting when a fault happens. This macro is exported by Mbed CLI 1 and used by mbed_error.c, so for compatibility we let CMake set the same name of macro.Fixes ARMmbed/mbed-tools#313
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers