Eth: STM32: Updating documentation on mbed_otp_mac_address() #14838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeromecoutant For your review. |
|
@katherrafi, thank you for your changes. |
jeromecoutant
approved these changes
Jun 30, 2021
0xc0170
previously requested changes
Jul 1, 2021
targets/TARGET_STM/README.md
Outdated
| can be changed. | ||
| Because as this is defined as weak in mbed-os/connectivity/drivers/emac/TARGET_STM/stm32xx_emac.cpp | ||
| ``` | ||
| __weak uint8_t mbed_otp_mac_address(char *mac). |
There was a problem hiding this comment.
as this is for Mbed OS, lets use MBED_WEAK instead
Suggested change
| __weak uint8_t mbed_otp_mac_address(char *mac). | |
| #include "platform/mbed_toolchain.h" | |
| MBED_WEAK uint8_t mbed_otp_mac_address(char *mac). |
There was a problem hiding this comment.
@0xc0170 Suggested changes are updated.
5d19e61 to
1e92540
Compare
| Because as this is defined as weak in mbed-os/connectivity/drivers/emac/TARGET_STM/stm32xx_emac.cpp | ||
| ``` | ||
| #include "platform/mbed_toolchain.h" | ||
| MBED_WEAK uint8_t mbed_otp_mac_address(char *mac). |
There was a problem hiding this comment.
There was a problem hiding this comment.
@jeromecoutant :
In the stm32xx_emac.cpp file all "__weak" are replaced with MBED_WEAK.
1e92540 to
a9e9564
Compare
This commit updates the documentation on how to use mbed_otp_mac_address() to modify the default MAC address to custom Mac address. Signed-off-by: Kather Rafi Ibrahim <[email protected]>
jeromecoutant
approved these changes
Jul 1, 2021
0xc0170
approved these changes
Jul 8, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the documentation on how to use
mbed_otp_mac_address() to modify the default MAC address to custom
Mac address.
Signed-off-by: Kather Rafi Ibrahim [email protected]
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers