Skip to content

BLE: support non-low power devices #14710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jun 1, 2021
Merged

BLE: support non-low power devices #14710

merged 1 commit into from Jun 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 26, 2021

Summary of changes

The Bluetooth API uses LowPowerTimer, LowPowerTicker and LowPowerTimeout objects for time-related operations. As result, compilation fails on targets that do not use these classes (e.g., Nucleo F3 targets).

This PR updates the code in connectivity/FEATURE_BLE/source/ such that, according to the target's capabilities, the correct timing primitives are used, enabling compilation on non-low power devices.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[ ] Feature update (New feature / Functionality change / New API)
[ ] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[ ] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[ ] Tests / results supplied as part of this PR

Reviewers

@pan- @MarceloSalazar


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label May 26, 2021
@ciarmcom
Copy link
Member

@noonfom, thank you for your changes.
@pan- @MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

pan-
pan- previously requested changes May 26, 2021
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good however it is not recommended to use using directives in the global scope. Can you move the using directives inside the class ? You need to slit import from using.

@mergify mergify bot dismissed pan-’s stale review May 27, 2021 09:11

Pull request has been modified.

@ghost ghost requested a review from pan- May 27, 2021 09:12
@mergify mergify bot added needs: CI and removed needs: work labels May 27, 2021
Copy link

@MarceloSalazar MarceloSalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels May 28, 2021
@0xc0170 0xc0170 removed the stale Stale Pull Request label May 31, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented May 31, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 0738aab into ARMmbed:master Jun 1, 2021
@mergify mergify bot removed the ready for merge label Jun 1, 2021
@mbedmain mbedmain added Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants