-
Notifications
You must be signed in to change notification settings - Fork 3k
BLE: support non-low power devices #14710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@noonfom, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good however it is not recommended to use using
directives in the global scope. Can you move the using
directives inside the class ? You need to slit import from using
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
The Bluetooth API uses
LowPowerTimer
,LowPowerTicker
andLowPowerTimeout
objects for time-related operations. As result, compilation fails on targets that do not use these classes (e.g., Nucleo F3 targets).This PR updates the code in connectivity/FEATURE_BLE/source/ such that, according to the target's capabilities, the correct timing primitives are used, enabling compilation on non-low power devices.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@pan- @MarceloSalazar