Skip to content

Pin name tests update #14704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2021
Merged

Pin name tests update #14704

merged 2 commits into from
Jun 9, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Minor updates:

  • hal-tests-tests-pin_names-arduino_uno: add an extra check for UART instance
  • hal-tests-tests-pin_names-generic: add BUTTON3 test

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label May 26, 2021
@ciarmcom ciarmcom requested a review from a team May 26, 2021 12:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions.

0xc0170
0xc0170 reviewed May 31, 2021
View reviewed changes
hal/tests/TESTS/pin_names/generic/main.cpp Outdated
@@ -26,7 +26,7 @@ Requirements specified in docs/design-documents/hal/0004-pin-names-general-guide

#ifndef LED1
#error [NOT_SUPPORTED] Target is not following mbed-os pin names standard // Test is set as Skipped
// #error [NOT_SUPPORTED] Target is not following mbed-os pin names standard // Test is set as Error
// #error Target is not following mbed-os pin names standard // Test is set as Error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we just remove this line completely?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During this test creation, idea was to set this test as error as pin names standard is mandatory.

After discussion with @MarceloSalazar test has been set as skipped (NOT_SUPPORTED) waiting for targets migration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an error (line 28) that we can fix later. we do not need to have this commented out code (line 29) ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ciarmcom ciarmcom removed the stale Stale Pull Request label May 31, 2021
@0xc0170 0xc0170 requested a review from gpsimenos June 7, 2021 18:54
@mergify mergify bot added needs: CI and removed needs: review labels Jun 7, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit fa090ff into ARMmbed:master Jun 9, 2021
@mergify mergify bot removed the ready for merge label Jun 9, 2021
@jeromecoutant jeromecoutant deleted the PR_TEST_PIN branch June 9, 2021 15:07
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@gpsimenos gpsimenos Awaiting requested review from gpsimenos

Assignees
No one assigned
Labels
component: hal release-version: 6.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @adbridge @mbedmain