Updated TARGET_STM32 board pinMap_PWM table with GPIO_NOPULL #14521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OPULL in print_pwm function
…d GPIO_PULLUP with GPIO_NOPULL in PinMap_PWM table
|
@AnishKumarHCL, thank you for your changes. |
jeromecoutant
approved these changes
Apr 9, 2021
0xc0170
approved these changes
Apr 13, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
This PR does not contain release version label after merging. |
|
Version label fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
removed pinmap api call from pwmout_init_direct api in pwmout_api.c
Modified STM32_gen_PeripheralPins.py script by replacing GPIO_PULLUP with GPIO_NOPULL in print_pwm function
Updated all STM32 target boards PeripheralPins.c and PeripheralPinMaps.h files by replacing PinMap_PWM table GPIO_PULLUP to GPIO_NOPULL
PWM PinMap table from PeripheralPins.c was like this :
{PA_0, PWM_2, STM_PIN_DATA_EXT(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF1_TIM2, 1, 0)},I have replaced GPIO_PULLUP with GPIO_NOPULL in all STM32 targets PeripheralPins.c / PeripheralPinMaps.h files.
{PA_0, PWM_2, STM_PIN_DATA_EXT(STM_MODE_AF_PP, GPIO_NOPULL, GPIO_AF1_TIM2, 1, 0)},In pwmout_api.c Line:200
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/pwmout_api.c#L200
removed pin_mode api call which hardcoded with PulNone.
STM32_gen_PeripheralPins.py aslo updated for generating PeripheralPins.c with PinMap_PWM table with GPIO_NOPULL
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@jeromecoutant please review this PR