Skip to content

CMake: Fix STM target build failures #14429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2021
Merged

CMake: Fix STM target build failures #14429

merged 1 commit into from
Mar 22, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Ensure the linker and startup files are listed with the correct letter case as some host systems are case sensitive.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@saheerb @0xc0170 @Patater @jeromecoutant

jeromecoutant
jeromecoutant suggested changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep the lower case,
and change the files ?

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 15, 2021
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@0xc0170 @saheerb @Patater @jeromecoutant @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team March 15, 2021 14:00
@hugueskamba
CMake: Fix STM target build failures
ff0756d 
Ensure the linker and startup files listed match
with the correct letter case as some host systems
are case sensitive.
@hugueskamba hugueskamba force-pushed the hk_cmake_fix_st_build_error branch from 4ec3291 to ff0756d Compare March 15, 2021 14:12
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2021

I would prefer to keep the lower case,
and change the files ?

If we can do it, let's do it. Aren't these imported and part of cmsis ?

@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Mar 15, 2021 •
edited
Loading

I would prefer to keep the lower case,
and change the files ?

Done

@jeromecoutant
Copy link
Collaborator

Aren't these imported and part of cmsis ?

No, linker scripts are specific to mbed

@mergify mergify bot added needs: CI and removed needs: review labels Mar 15, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2021

Ci failed (internal error), we will investigate

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 6a25287 into ARMmbed:master Mar 22, 2021
@mergify mergify bot removed the ready for merge label Mar 22, 2021
@hugueskamba hugueskamba deleted the hk_cmake_fix_st_build_error branch March 22, 2021 11:55
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@Patater Patater Awaiting requested review from Patater

@saheerb saheerb Awaiting requested review from saheerb

Assignees
No one assigned
Labels
devices: st release-version: 6.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugueskamba @ciarmcom @0xc0170 @jeromecoutant @mbed-ci @mbedmain