Skip to content

CMake targets: remove labels usage, not required anymore #14428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Mar 15, 2021

Summary of changes

As targets refactor was completed, this can be removed. I could not find any usage of targets labels in targets folder, this was the last one.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@0xc0170 0xc0170 requested review from hugueskamba and rajkan01 March 15, 2021 11:45
@0xc0170 0xc0170 force-pushed the cmake-fix-targets-labels branch from 4b29e2c to c67dfbe Compare March 15, 2021 11:45
@0xc0170 0xc0170 force-pushed the cmake-fix-targets-labels branch from c67dfbe to ad8b9f6 Compare March 15, 2021 11:46
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 15, 2021
@ciarmcom ciarmcom requested a review from a team March 15, 2021 12:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 16, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 16, 2021

One duplication found

CMake Error at mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/CMakeLists.txt:11 (add_library):
add_library cannot create target "mbed-mcuxpresso-mcus" because another
target with the same name already exists. The existing target is an
interface library created in source directory
"/builds/workspace/mbed-os-ci_cmake-example-ARM@8/examples/mbed-os-example-blinky/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS".
See documentation for policy CMP0002 for more details.

I'll fix this one now

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 16, 2021

Fixed, restarting CI

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit b7f1acf into ARMmbed:master Mar 22, 2021
@0xc0170 0xc0170 deleted the cmake-fix-targets-labels branch March 22, 2021 09:56
@mergify mergify bot removed the ready for merge label Mar 22, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants