Skip to content

CMake: Fix Greentea tests #14328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2021
Merged

CMake: Fix Greentea tests #14328

merged 1 commit into from
Feb 24, 2021

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Feb 23, 2021 •
edited
Loading

Summary of changes

  • Specify new Greentea tests build steps in README
  • Correct path to generated CMake configuration module

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

rajkan01
rajkan01 previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugueskamba
Copy link
Collaborator Author

LGTM

Please have a look at the known issue just added in the PR description.

@rajkan01
Copy link
Contributor

rajkan01 commented Feb 23, 2021 •
edited
Loading

LGTM

LGTM

Please have a look at the known issue just added in the PR description.

If I am not wrong these PR changes triggered by this PR ARMmbed/mbed-tools#189 changes as moved mbed_build.cmake from root to the current build directory

@mergify mergify bot added the needs: CI label Feb 23, 2021
@hugueskamba hugueskamba force-pushed the hk_cmake_fix_greentea_tests branch from 632fc76 to 04858fa Compare February 23, 2021 13:04
@mergify mergify bot dismissed rajkan01’s stale review February 23, 2021 13:05

Pull request has been modified.

@hugueskamba
CMake: Fix Greentea tests
1ba3b73 
* Specify new Greentea tests build steps in README
* Correct path to generated CMake configuration module
@hugueskamba hugueskamba force-pushed the hk_cmake_fix_greentea_tests branch from 04858fa to 1ba3b73 Compare February 23, 2021 13:09
@hugueskamba
Copy link
Collaborator Author

LGTM

LGTM

Please have a look at the known issue just added in the PR description.

If I am not wrong these PR changes triggered by this PR ARMmbed/mbed-tools#189 changes as moved mbed_build.cmake from root to the current build directory

This force-push fixes the issue with the location of the artefacts.

@hugueskamba hugueskamba requested a review from rajkan01 February 23, 2021 13:10
@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Feb 23, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 23, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 23, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 737153b into ARMmbed:master Feb 24, 2021
@mergify mergify bot removed the ready for merge label Feb 24, 2021
@hugueskamba hugueskamba deleted the hk_cmake_fix_greentea_tests branch February 27, 2021 02:39
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@harmut01 harmut01 Awaiting requested review from harmut01

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugueskamba @rajkan01 @0xc0170 @mbed-ci @mbedmain