Skip to content

BLE: fix indexing of array in Cordio host stack #14305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2021
Merged

BLE: fix indexing of array in Cordio host stack #14305

merged 3 commits into from
Feb 23, 2021

Conversation

paul-szczepanek-arm
Copy link
Member

Summary of changes

The array was being indexed by handle instead of connection id as it's intended which results in reading random memory. There are two calls in cordio that use the attsCsfActClientState differently - one passes in handle, one passes in conn id (actually conn id - 1), this is now normalised to accept conn id.

Impact of changes

Migration actions required

Documentation

none

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan- @mprse

@paul-szczepanek-arm
fix Cordio attsCsfActClientState index parameter
b271ee8 
instead of using a handle this should be conn id
there were two calls using it differently
@paul-szczepanek-arm
Copy link
Member Author

paul-szczepanek-arm commented Feb 19, 2021 •
edited
Loading

This PR is not ready for merge or even CI yet. I'm putting it up here for review. Thank you @mprse for finding the problem.

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 19, 2021
@ciarmcom ciarmcom requested review from mprse, pan- and a team February 19, 2021 13:00
@ciarmcom
Copy link
Member

@paul-szczepanek-arm, thank you for your changes.
@mprse @pan- @ARMmbed/mbed-os-maintainers please review.

mprse
mprse approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connection stability increased significantly.

@paul-szczepanek-arm
Copy link
Member Author

I'm still running the test-suite (having some local issues) but it looks largely OK and is also validated by the fact that Packetcraft fixed this upstream in the meantime.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2021

CI started

@mergify mergify bot removed the needs: review label Feb 22, 2021
@mbed-ci
Copy link

mbed-ci commented Feb 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2021

I'm still running the test-suite (having some local issues) but it looks largely OK and is also validated by the fact that Packetcraft fixed this upstream in the meantime.

We will wait with merging. Set this back to review

@paul-szczepanek-arm
Copy link
Member Author

All (working) tests passed.

@0xc0170 0xc0170 merged commit 8340ea2 into ARMmbed:master Feb 23, 2021
@mergify mergify bot removed the ready for merge label Feb 23, 2021
@mbedmain mbedmain added Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@mprse mprse mprse approved these changes

Assignees
No one assigned
Labels
component: connectivity release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@paul-szczepanek-arm @ciarmcom @0xc0170 @mbed-ci @pan- @mprse @mbedmain