Skip to content

CMake: Refactor post-build hook to remove APP_TARGET references #14304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

CMake: Refactor post-build hook to remove APP_TARGET references #14304

merged 1 commit into from
Feb 25, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

There should not be a reference to APP_TARGET in Mbed OS as end-users
may decide to use a different name for the CMake variable to store their
application name.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba
CMake: Refactor post-build hook to remove APP_TARGET references
0eae4f6 
There should not be a reference to APP_TARGET in Mbed OS as end-users
may decide to use a different name for the CMake variable to store their
application name.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 19, 2021
@ciarmcom ciarmcom requested a review from a team February 19, 2021 12:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 22, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2021

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2021

Waiting although for more reviews, this is important fix.

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 requested a review from rwalton-arm February 22, 2021 15:59
@0xc0170 0xc0170 merged commit 7da6100 into ARMmbed:master Feb 25, 2021
@mergify mergify bot removed the ready for merge label Feb 25, 2021
@hugueskamba hugueskamba deleted the hk_cmake_remove_app_target_reference branch February 27, 2021 02:39
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@rajkan01 rajkan01 Awaiting requested review from rajkan01

@harmut01 harmut01 Awaiting requested review from harmut01

@rwalton-arm rwalton-arm Awaiting requested review from rwalton-arm

Assignees
No one assigned
Labels
component: tools release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @mbedmain