Skip to content

CMake: Refactor mapfile generation #14299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

CMake: Refactor mapfile generation #14299

merged 1 commit into from
Feb 25, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

The refactoring was necessary to remove a function call
(mbed_configure_app_target()) from application's CMakeLists.txt.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 17, 2021
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 17, 2021 18:00
0xc0170
0xc0170 reviewed Feb 18, 2021
View reviewed changes
0xc0170
0xc0170 reviewed Feb 18, 2021
View reviewed changes
@hugueskamba hugueskamba force-pushed the hk_cmake_refactor_mapfile_generation branch from 4f5528e to 7756dcf Compare February 19, 2021 15:03
@hugueskamba hugueskamba mentioned this pull request Feb 22, 2021
Merged
@0xc0170 0xc0170 requested a review from rwalton-arm February 22, 2021 20:14
@mergify
Copy link

mergify bot commented Feb 23, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170 0xc0170 self-requested a review February 23, 2021 08:37
@hugueskamba hugueskamba force-pushed the hk_cmake_refactor_mapfile_generation branch from 7756dcf to 441ae8b Compare February 23, 2021 11:36
@hugueskamba
CMake: Refactor mapfile generation
ed09a5c 
The refactoring was necessary to remove a function call
(mbed_configure_app_target()) from application's CMakeLists.txt.
@hugueskamba hugueskamba force-pushed the hk_cmake_refactor_mapfile_generation branch from 441ae8b to ed09a5c Compare February 23, 2021 11:41
@hugueskamba
Copy link
Collaborator Author

This force-push fixes the merge conflict by rebasing from master.

@mergify mergify bot added needs: CI and removed needs: work labels Feb 23, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 23, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 23, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit eceaea5 into ARMmbed:master Feb 25, 2021
@mergify mergify bot removed the ready for merge label Feb 25, 2021
@LDong-Arm LDong-Arm mentioned this pull request Feb 25, 2021
Merged
@hugueskamba hugueskamba deleted the hk_cmake_refactor_mapfile_generation branch February 27, 2021 02:44
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@rajkan01 rajkan01 Awaiting requested review from rajkan01

@rwalton-arm rwalton-arm Awaiting requested review from rwalton-arm

Assignees
No one assigned
Labels
component: tools release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @mbedmain