Skip to content

Fix up some ST CMake targets #14266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 11, 2021

Conversation

rwalton-arm
Copy link
Contributor

Summary of changes

Some targets weren't factored correctly when the ST target CMake files were changed.
Previously some of the ST targets were implicitly created through various add_subdirectory calls to add the correct source code. So they were missed when we introduced the CMake targets for Mbed targets.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@Patater @0xc0170

@rwalton-arm rwalton-arm force-pushed the dev/rwalton-arm/fix-st-targets branch from a361099 to 2daa58f Compare February 10, 2021 14:28
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 10, 2021
@ciarmcom ciarmcom requested review from 0xc0170, Patater and a team February 10, 2021 14:30
@ciarmcom
Copy link
Member

@rwalton-arm, thank you for your changes.
@Patater @0xc0170 @ARMmbed/team-st-mcd @ARMmbed/mbed-os-maintainers please review.

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with 70 targets with STM32.

All OK except FF1705_L151CC

0xc0170
0xc0170 previously approved these changes Feb 10, 2021
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed some of these in #14255 (I can see disco h7 I was just fixing but not correctly, as here
to create base m4/m7 targets).

FF1705_L151CC

This one should be addressed in 14255 , creating a new CMake target that just links to another one.

Can we base this on top of the 14255 ? I would like to get the bigger one in as it blocks couple of PRs.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 10, 2021
@rwalton-arm rwalton-arm force-pushed the dev/rwalton-arm/fix-st-targets branch from 2daa58f to 4591fd8 Compare February 10, 2021 16:13
@mergify mergify bot dismissed 0xc0170’s stale review February 10, 2021 16:13

Pull request has been modified.

@rwalton-arm
Copy link
Contributor Author

I've noticed some of these in #14255 (I can see disco h7 I was just fixing but not correctly, as here
to create base m4/m7 targets).

FF1705_L151CC

This one should be addressed in 14255 , creating a new CMake target that just links to another one.

Can we base this on top of the 14255 ? I would like to get the bigger one in as it blocks couple of PRs.

I rebased on your branch but the history is now a mess, so I'll wait for your PR to go in before I fix that up.

@jeromecoutant
Copy link
Collaborator

Hi
I think you need to rebase
Thx

@rwalton-arm rwalton-arm force-pushed the dev/rwalton-arm/fix-st-targets branch from 4591fd8 to ab7a530 Compare February 11, 2021 09:34
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 2f7728e into ARMmbed:master Feb 11, 2021
@mergify mergify bot removed the ready for merge label Feb 11, 2021
@mbedmain mbedmain added release-version: 6.8.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants