-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix up some ST CMake targets #14266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up some ST CMake targets #14266
Conversation
a361099
to
2daa58f
Compare
@rwalton-arm, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with 70 targets with STM32.
All OK except FF1705_L151CC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed some of these in #14255 (I can see disco h7 I was just fixing but not correctly, as here
to create base m4/m7 targets).
FF1705_L151CC
This one should be addressed in 14255 , creating a new CMake target that just links to another one.
Can we base this on top of the 14255 ? I would like to get the bigger one in as it blocks couple of PRs.
2daa58f
to
4591fd8
Compare
Pull request has been modified.
I rebased on your branch but the history is now a mess, so I'll wait for your PR to go in before I fix that up. |
Hi |
4591fd8
to
ab7a530
Compare
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Some targets weren't factored correctly when the ST target CMake files were changed.
Previously some of the ST targets were implicitly created through various
add_subdirectory
calls to add the correct source code. So they were missed when we introduced the CMake targets for Mbed targets.Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@Patater @0xc0170