-
Notifications
You must be signed in to change notification settings - Fork 3k
Support STM Nucleo-G431RB #14259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support STM Nucleo-G431RB #14259
Conversation
@rotu, thank you for your changes. |
I'm not sure that the clock setup is correct. The debugger seems to drop out when calling ThisThread::sleep_for(...) but I have no idea how to troubleshoot/fix this. |
@rotu thanks for your contribution. |
@rotu I assume testing fails as well, so no test results available at the moment. Once you fix, please attach the logs to the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems correct.
About you debug issue, did you work on top on 6.6.0 release ?
(because there was an issue, go with 6.7.0)
I was under the impression that calling |
I don't know how to run tests canonically. The output of
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
This pull request has automatically been marked as stale because it has had no recent activity. @rotu, please carry out any necessary work to get the changes merged. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First tests done => all OK
Need to redo CMakeLists files with the new rules.
This is the correct command.
This error :
is not normal. This is because you can't have a main.cpp file in your root directory during test... |
|
||
USBTX = STDIO_UART_TX, // used for greentea tests | ||
USBRX = STDIO_UART_RX, // used for greentea tests | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could add Arduino pins definitions here ? :-)
@rotu for future reference you should use rebase not merge , thanks. |
@adbridge rebased |
|
I have no idea how to interpret these outputs. It seems DeepSleepLock test passes.
but later on in the log it says "mbedgt: :191::FAIL: Deepsleep should be allowed.":
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note you changed 2 files in targets/TARGET_STM/TARGET_STM32L1/TARGET_STM32L152xC/TARGET_MOTE_L152RC
Please revert these two and this should be ready for CI |
@jeromecoutant, @adbridge I still have some problems with the tests which make me doubt that passing CI would be sufficient. Some tests are showing failure messages after the test cases themselves have passed. I'm way out of my depth here. |
rebased onto master and fixed breaking changes |
Still having weird test problems after rebasing on master and fixing build bugs:
|
I don't know, everything is working well on my side:
Using ARM Compiler 6.15 and
|
Travis CI is failing due to the new pin standard feature. |
Great! If you can't see it then it's probably Murphy's Law on my end.
Pulled it in! Thank you so much! |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Support the STM Nucleo-G431RB board
Impact of changes
Migration actions required
Documentation
Support the STM Nucleo-G431RB board
Pull request type
Test results
Reviewers