Skip to content

Add cortex-m55 to CMake support #14213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2021
Merged

Add cortex-m55 to CMake support #14213

merged 2 commits into from
Feb 3, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jan 28, 2021 •
edited
Loading

Summary of changes

Adding Cortex M55 as requested to CMake. I assume we do not add it to the old tools.

I'll run some local tests, as we do not have yet a target m55 in the tree. I verified we got at least CMSIS version in the treethat supports m55 (lucky us we updated it few months back :)). armclang and gcc as well, but will test if the versions we use have it already.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 28, 2021
@ciarmcom ciarmcom requested review from a team January 28, 2021 17:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

MarceloSalazar
MarceloSalazar previously approved these changes Jan 29, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Jan 29, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 29, 2021 •
edited
Loading

As we do not have m55 in the tree, I tried to redefine one of the target to see if the compiler does not complain about inputs coming from this PR.
ARMClang 6.14: OK, cortex-m55 options recognized
arm-none-eabi-gcc (GNU Arm Embedded Toolchain 9-2020-q2-update) 9.3.1 20200408 (release): fails, cortex-m55 not recognized

Whoever uses this should use gcc arm 10, see release notes:

Notable changes in 2020-q4-major release:

  • Added support for:
  • M-profile Vector Extension (MVE) assembler and intrinsics
  • Custom Datapath Extension (CDE)
  • Cortex-M55

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 29, 2021

This means we should update to gcc arm 10 in a release where we want to support cortex-m55. I'll talk to the @ARMmbed/mbed-os-tools

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 29, 2021

I'll amend the commit message stating this update will require Gcc Arm 10 from 2020 Q4. I would go ahead to get this in for interested parties and we can coordinate toolchain update for the next release separately. This is just a boiler plate anyway (no target).

@Patater
Copy link
Contributor

Patater commented Jan 29, 2021

OK as a starting point for making an actual target.

Patater
Patater previously approved these changes Jan 29, 2021
View reviewed changes
hugueskamba
hugueskamba reviewed Jan 29, 2021
View reviewed changes
Copy link
Collaborator

@hugueskamba hugueskamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also need something here: https://github.com/ARMmbed/mbed-os/blob/master/cmsis/CMSIS_5/CMSIS/RTOS2/RTX/CMakeLists.txt ?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 29, 2021

Do you also need something here: https://github.com/ARMmbed/mbed-os/blob/master/cmsis/CMSIS_5/CMSIS/RTOS2/RTX/CMakeLists.txt ?

Yes! Another place forgotten, fixing now

@mergify mergify bot dismissed stale reviews from MarceloSalazar and Patater January 29, 2021 14:23

Pull request has been modified.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 29, 2021

Fixed !

@hugueskamba
Copy link
Collaborator

Do we need to add a directory here and then modify https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_ARM_FM/TARGET_FVP_MPS2/CMakeLists.txt#L4 ?

@mergify mergify bot added needs: work and removed needs: CI labels Jan 29, 2021
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 29, 2021

nfc failure, will be fixed once we release, and I'll restart the CI

@mbed-ci
Copy link

mbed-ci commented Jan 29, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 1, 2021

The failure is known, will be fixed in the example

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 2, 2021

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 3, 2021 •
edited
Loading

As approved previously, I'll merge it.

@0xc0170 0xc0170 merged commit d48cc29 into ARMmbed:master Feb 3, 2021
@0xc0170 0xc0170 deleted the dev_add_cortexm55 branch February 3, 2021 09:39
@mergify mergify bot removed the ready for merge label Feb 3, 2021
@mbedmain mbedmain added release-version: 6.8.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugueskamba hugueskamba hugueskamba left review comments

@Patater Patater Patater left review comments

@MarceloSalazar MarceloSalazar MarceloSalazar left review comments

Assignees
No one assigned
Labels
release-version: 6.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@0xc0170 @ciarmcom @Patater @hugueskamba @mbed-ci @MarceloSalazar @mbedmain