Skip to content

Upgrade gtest to 1.10 #14197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Upgrade gtest to 1.10 #14197

merged 2 commits into from
Feb 1, 2021

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Jan 26, 2021

Summary of changes

We want to use the new and easier to use MOCK_METHOD. The upgrade is backwards compatible.

The fixes applied are to add a missing namespace.

Impact of changes

Migration actions required

Documentation

none


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-


pan-
pan- previously approved these changes Jan 26, 2021
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul.
One of the major change is that gtest/gmock doesn't keep the pre C++11 support. This change should improved compilation time because it requires less template instantiation.

@pan- pan- requested review from saheerb and donatieng January 26, 2021 17:29
@pan-
Copy link
Member

pan- commented Jan 26, 2021

@0xc0170 We know it is a feature branch but we would like unit test run on this one. It doesn't seems to be covered by the travis check somehow.

@mergify mergify bot added the needs: CI label Jan 26, 2021
0xc0170
0xc0170 previously approved these changes Jan 27, 2021
@mergify mergify bot dismissed stale reviews from pan- and 0xc0170 January 27, 2021 12:49

Pull request has been modified.

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jan 27, 2021
@mbed-ci
Copy link

mbed-ci commented Jan 27, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️

@0xc0170 0xc0170 merged commit 956b197 into ARMmbed:master Feb 1, 2021
@mergify mergify bot removed the ready for merge label Feb 1, 2021
@mbedmain mbedmain added release-version: 6.8.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants