Skip to content

LoraRadio test update for baremetal support #14195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

LoraRadio test update for baremetal support #14195

merged 1 commit into from
Feb 3, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

  • Test is simplified with direct use of COMPONENT macro check
  • RTOS requirement is removed

Test is now OK with default and baremetal configurations for DISCO_L072CZ_LRWAN1:

| target                    | platform_name       | test suite                                         | test case                  | passed | failed | result | elapsed_time (sec) |
|---------------------------|---------------------|----------------------------------------------------|----------------------------|--------|--------|--------|--------------------|
| DISCO_L072CZ_LRWAN1-ARMC6 | DISCO_L072CZ_LRWAN1 | connectivity-lorawan-tests-tests-lorawan-loraradio | Test check_rf_frequency    | 1      | 0      | OK     | 0.06               |
| DISCO_L072CZ_LRWAN1-ARMC6 | DISCO_L072CZ_LRWAN1 | connectivity-lorawan-tests-tests-lorawan-loraradio | Test perform_carrier_sense | 1      | 0      | OK     | 0.06               |
| DISCO_L072CZ_LRWAN1-ARMC6 | DISCO_L072CZ_LRWAN1 | connectivity-lorawan-tests-tests-lorawan-loraradio | Test random                | 1      | 0      | OK     | 0.1                |
| DISCO_L072CZ_LRWAN1-ARMC6 | DISCO_L072CZ_LRWAN1 | connectivity-lorawan-tests-tests-lorawan-loraradio | Test set_rx_config         | 1      | 0      | OK     | 0.09               |
| DISCO_L072CZ_LRWAN1-ARMC6 | DISCO_L072CZ_LRWAN1 | connectivity-lorawan-tests-tests-lorawan-loraradio | Test set_tx_config         | 1      | 0      | OK     | 0.08               |
| DISCO_L072CZ_LRWAN1-ARMC6 | DISCO_L072CZ_LRWAN1 | connectivity-lorawan-tests-tests-lorawan-loraradio | Test time_on_air           | 1      | 0      | OK     | 0.06               |

@ludoch-stm

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 26, 2021
@ciarmcom ciarmcom requested review from a team January 26, 2021 14:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

pan-
pan- approved these changes Jan 26, 2021
View reviewed changes
connectivity/lorawan/tests/TESTS/lorawan/loraradio/main.cpp
TEST_ASSERT_EQUAL(EV_NONE, received_event);
received_event = EV_TX_TIMEOUT;
TEST_ASSERT_EQUAL(osOK, event_sem.release());
}

static void rx_done(const uint8_t *payload, uint16_t size, int16_t rssi, int8_t snr)
{
rtos::ThisThread::sleep_for(2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why these sleep where present in the first place ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I am quite new in lora....

@mergify mergify bot added needs: CI and removed needs: review labels Jan 26, 2021
0xc0170
0xc0170 approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works for various radios (without the timeouts there).

@jeromecoutant
Copy link
Collaborator Author

If this works for various radios (without the timeouts there).

It works for coming STM32WL55 .... :-)

@jeromecoutant
Copy link
Collaborator Author

@pan-
Who could update doc page: https://os.mbed.com/docs/mbed-os/v6.6/bare-metal/index.html#features
in order to add LoRa ?
Thx

@ciarmcom ciarmcom added the stale Stale Pull Request label Jan 28, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@jeromecoutant
Copy link
Collaborator Author

Let's start CI ?
Thx

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 2, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 40cd330 into ARMmbed:master Feb 3, 2021
@mergify mergify bot removed the ready for merge label Feb 3, 2021
@jeromecoutant jeromecoutant deleted the PR_LORA_BARE branch February 3, 2021 09:34
@jeromecoutant
Copy link
Collaborator Author

Who could update doc page: https://os.mbed.com/docs/mbed-os/v6.6/bare-metal/index.html#features
in order to add LoRa ?
Thx

Kind reminder :-)

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 3, 2021

@paul-szczepanek-arm Can you add the docs please?

@paul-szczepanek-arm paul-szczepanek-arm mentioned this pull request Feb 3, 2021
Merged
@paul-szczepanek-arm
Copy link
Member

ARMmbed/mbed-os-5-docs#1409

@mbedmain mbedmain added release-version: 6.8.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.8.0 stale Stale Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @paul-szczepanek-arm @pan- @mbedmain