tests: Limit PSA crypto tests to Arm-v7M targets #14126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@urutva, thank you for your changes. |
Patater
previously requested changes
Jan 12, 2021
The test `test_crypto_asymmetric_encrypt_decrypt` was incorrectly setting the key usage flags. The key usage is updated to support both encryption and decryption. Signed-off-by: Devaraj Ranganna <[email protected]>
The PSA crypto tests in connectivity/mbedtls/tests/TESTS/mbedtls/sanity/main.cpp are only supported for Arm-v7M PSA targets. For Arm-v8M PSA targets, crypto regression tests provided by TF-M are used. Refer to https://github.com/ARMmbed/mbed-os-tf-m-regression-tests for more information. Signed-off-by: Devaraj Ranganna <[email protected]>
63d08d3 to
61009ba
Compare
Patater
approved these changes
Jan 20, 2021
0xc0170
approved these changes
Jan 20, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The PSA crypto tests in
connectivity/mbedtls/tests/TESTS/mbedtls/sanity/main.cppare only supported for Arm-v7M PSA targets. For Arm-v8M PSA targets, crypto regression tests provided by TF-M are used. Refer to https://github.com/ARMmbed/mbed-os-tf-m-regression-tests for more information.Impact of changes
None, for Arm-v8M PSA targets, crypto regression tests provided by TF-M are used.
Migration actions required
NA
Documentation
NA
Pull request type
Test results
Reviewers
@Patater @evedon @jainvikas8 @hugueskamba