Skip to content

CMake: Add CMake support for events greentea test #14095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2021
Merged

CMake: Add CMake support for events greentea test #14095

merged 2 commits into from
Jan 11, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Dec 25, 2020 •
edited
Loading

Summary of changes

  • Added CMakeLists.txt file to every test suite under the events so that it can build via CMake command

Impact of changes

None.

Migration actions required

Note

Documentation

None.

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba @0xc0170

@mergify mergify bot added the needs: work label Dec 25, 2020
@ciarmcom ciarmcom requested review from 0xc0170, hugueskamba and a team December 25, 2020 01:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@hugueskamba @0xc0170 @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team December 25, 2020 01:00
hugueskamba
hugueskamba reviewed Dec 29, 2020
View reviewed changes
@rajkan01 rajkan01 requested a review from hugueskamba December 29, 2020 11:55
@mergify mergify bot removed the needs: review label Dec 29, 2020
hugueskamba
hugueskamba previously approved these changes Dec 29, 2020
View reviewed changes
@rajkan01 rajkan01 force-pushed the add_cmake_greentea_events branch from 3342e03 to 163a9f3 Compare January 5, 2021 14:56
@mergify mergify bot dismissed hugueskamba’s stale review January 5, 2021 14:57

Pull request has been modified.

@rajkan01 rajkan01 force-pushed the add_cmake_greentea_events branch from 163a9f3 to accf24a Compare January 5, 2021 17:11
@rajkan01
Copy link
Contributor Author

rajkan01 commented Jan 5, 2021 •
edited
Loading

@0xc0170 @adbridge This PR is ready for CI, please start the CI

@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2021

@hugueskamba could you re-review please

@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 6, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ❌

@mergify mergify bot added needs: work and removed needs: CI labels Jan 6, 2021
@rajkan01
Copy link
Contributor Author

rajkan01 commented Jan 6, 2021

@adbridge CI error related to mbed CLI deploy command with BLE example, could you restart CI example build for ARM toolchain

[2021-01-06T15:10:10.320Z] [EXAMPLES]> INFO     In folder 'mbed-os-example-ble'
[2021-01-06T15:10:10.320Z] [EXAMPLES]> INFO     Executing command 'mbed-cli deploy'...
[2021-01-06T16:30:07.664Z] Sending interrupt signal to process
[2021-01-06T16:30:19.199Z] [mbed] ERROR: Unable to clone repository (https://github.com/ARMmbed/mbed-os-ble-utils/#5a87e640383b2a1465e19ea6c052f80459314670)
[2021-01-06T16:30:19.199Z] ---
[2021-01-06T16:30:19.199Z] [mbed] Working path "/builds/workspace/mbed-os-ci_build-example-ARM@3/examples/mbed-os-example-ble" (program)
[2021-01-06T16:30:19.199Z] [mbed] Adding library "BLE_GattServer_CharacteristicWrite/mbed-os-ble-utils" from "https://github.com/ARMmbed/mbed-os-ble-utils" at rev #5a87e640383b
[2021-01-06T16:30:19.199Z] [mbed] Adding library "BLE_Advertising/mbed-os-ble-utils" from "https://github.com/ARMmbed/mbed-os-ble-utils" at rev #5a87e640383b
[2021-01-06T16:30:19.199Z] [mbed] Adding library "BLE_SecurityAndPrivacy/mbed-os-ble-utils" from "https://github.com/ARMmbed/mbed-os-ble-utils" at rev #5a87e640383b
[2021-01-06T16:30:19.199Z] [mbed] Adding library "BLE_GAP/mbed-os-ble-utils" from "https://github.com/ARMmbed/mbed-os-ble-utils" at rev #5a87e640383b
[2021-01-06T16:30:19.199Z] [mbed] Adding library "BLE_PeriodicAdvertising/mbed-os-ble-utils" from "https://github.com/ARMmbed/mbed-os-ble-utils" at rev #5a87e640383b
[2021-01-06T16:30:19.199Z] [mbed] Adding library "BLE_GattClient_CharacteristicUpdates/mbed-os-ble-utils" from "https://github.com/ARMmbed/mbed-os-ble-utils" at rev #5a87e640383b
[2021-01-06T16:30:19.199Z] [mbed] Adding library "BLE_GattServer_AddService/mbed-os-ble-utils" from "https://github.com/ARMmbed/mbed-os-ble-utils" at rev #5a87e640383b
[2021-01-06T16:30:19.199Z] [mbed] Adding library "BLE_GattServer_CharacteristicUpdates/mbed-os-ble-utils" from "https://github.com/ARMmbed/mbed-os-ble-utils" at rev #5a87e640383b
[2021-01-06T16:30:19.199Z] [mbed] Adding library "BLE_GattClient_CharacteristicWrite/mbed-os-ble-utils" from "https://github.com/ARMmbed/mbed-os-ble-utils" at rev #5a87e640383b
[2021-01-06T16:30:19.199Z] [EXAMPLES]> ERROR    mbed-cli deploy command failed for 'mbed-os-example-ble'
[2021-01-06T16:30:19.199Z] Terminated
[2021-01-06T16:30:19.204Z] script returned exit code 143
[2021-01-06T16:30:19.230Z] Running shell script failed
[2021-01-06T16:30:19.779Z] + python reporting_as_junit.py --suite-name EP_AGORA-ARM --test-group build --test-name setup-examples --time 4851.371 --stdout org.jenkinsci.plugins.workflow.steps.FlowInterruptedException --stderr Error: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

@adbridge
Copy link
Contributor

adbridge commented Jan 7, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

hugueskamba
hugueskamba reviewed Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@hugueskamba hugueskamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajkan01 There are comments that have not been addressed.

@rajkan01
Copy link
Contributor Author

rajkan01 commented Jan 8, 2021

@rajkan01 There are comments that have not been addressed.

@hugueskamba I have addressed the review comments, please re-review

@mergify mergify bot added needs: CI and removed needs: work labels Jan 8, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 8e6a015 into ARMmbed:master Jan 11, 2021
@mergify mergify bot removed the ready for merge label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugueskamba hugueskamba hugueskamba approved these changes

@0xc0170 0xc0170 Awaiting requested review from 0xc0170

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rajkan01 @ciarmcom @adbridge @mbed-ci @0xc0170 @hugueskamba @mbedmain