Skip to content

NFC: Add support for M24SR driver #14092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 24, 2020

Summary of changes

The repository https://github.com/ARMmbed/mbed-nfc-m24sr is no longer required to build applications that require
the M24SR driver. As shown by this: ARMmbed/mbed-os-example-nfc#94

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@hugueskamba hugueskamba requested review from pan-, paul-szczepanek-arm and a team December 24, 2020 17:26
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 24, 2020
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@hugueskamba
Copy link
Collaborator Author

This force-push rebases from master to fix the CI issue.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2021

Please fix the style (travis failed).

@hugueskamba
Copy link
Collaborator Author

Please fix the style (travis failed).

Done.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2021

Still failing

@mergify mergify bot added needs: work and removed needs: CI labels Jan 15, 2021
@mbed-ci
Copy link

mbed-ci commented Jan 15, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM
jenkins-ci/mbed-os-ci_build-example-GCC_ARM
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️

@hugueskamba
Copy link
Collaborator Author

Still failing

What is? Astyle?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2021

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2021

Once travis is green, I'll restart CI

@mergify mergify bot dismissed Patater’s stale review January 26, 2021 10:34

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 26, 2021

I thought a confirmation from the file owner was needed to add the SPDX. I will add it now.

I don't think so as it maps what it's already there (we are not changing the license). The only problem is that if this comes from upstream, it will be overwritten. But that is not the case here.

@mergify mergify bot added needs: CI and removed needs: work labels Jan 26, 2021
@avilei
Copy link

avilei commented Jan 26, 2021

@jeromecoutant @pan- @Patater
The SPDX added by @hugueskamba is fine with me.

@ciarmcom ciarmcom added the stale Stale Pull Request label Jan 28, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@hugueskamba
Copy link
Collaborator Author

@0xc0170 Can you please run CI?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2021

CI started

@paul-szczepanek-arm
Copy link
Member

I have reverted the example to avoid having it broken. @0xc0170 when you're ready to run CI again let me know before you kick it off.

I pushed the change again but it might be too late for the CI to pass.

@mergify mergify bot added needs: work and removed needs: CI labels Jan 29, 2021
@mbed-ci
Copy link

mbed-ci commented Jan 29, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 7 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM
jenkins-ci/mbed-os-ci_build-example-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2021

I'll restart , need to complete thje release first.

@ciarmcom ciarmcom removed the stale Stale Pull Request label Jan 29, 2021
@mbed-ci
Copy link

mbed-ci commented Feb 1, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 8 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 04100a1 into ARMmbed:master Feb 1, 2021
@mergify mergify bot removed the ready for merge label Feb 1, 2021
@hugueskamba hugueskamba deleted the hk_nfc_m24sr_support branch February 2, 2021 14:33
@mbedmain mbedmain added release-version: 6.8.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants