-
Notifications
You must be signed in to change notification settings - Fork 3k
NFC: Add support for M24SR driver #14092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hugueskamba, thank you for your changes. |
274f4d1
to
4711660
Compare
This force-push rebases from master to fix the CI issue. |
Please fix the style (travis failed). |
4711660
to
f03a4e2
Compare
Done. |
Still failing |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
What is? Astyle? |
Once travis is green, I'll restart CI |
f03a4e2
to
7e78a35
Compare
I don't think so as it maps what it's already there (we are not changing the license). The only problem is that if this comes from upstream, it will be overwritten. But that is not the case here. |
@jeromecoutant @pan- @Patater |
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
@0xc0170 Can you please run CI? |
CI started |
I pushed the change again but it might be too late for the CI to pass. |
Jenkins CI Test : ❌ FAILEDBuild Number: 7 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
I'll restart , need to complete thje release first. |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 8 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
The repository https://github.com/ARMmbed/mbed-nfc-m24sr is no longer required to build applications that require
the M24SR driver. As shown by this: ARMmbed/mbed-os-example-nfc#94
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers