-
Notifications
You must be signed in to change notification settings - Fork 3k
CMake: Add Blockdevice dependency to KVstore library #14079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
0xc0170
merged 1 commit into
ARMmbed:master
from
hugueskamba:hk_cmake_kvstore_dependency
Jan 4, 2021
Merged
CMake: Add Blockdevice dependency to KVstore library #14079
0xc0170
merged 1 commit into
ARMmbed:master
from
hugueskamba:hk_cmake_kvstore_dependency
Jan 4, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As KVstore relies on BlockDevice add the dependency in Mbed OS so applications do not have to specify it
@hugueskamba, thank you for your changes. |
rajkan01
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
harmut01
previously requested changes
Dec 21, 2020
Add comments instead of change requests and blocking PR if unsure
harmut01
approved these changes
Dec 22, 2020
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As KVstore relies on BlockDevice, add the dependency
in Mbed OS so applications do not have to specify it.
Needed by ARMmbed/mbed-os-example-kvstore#69
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers