Skip to content

CMake: Add Blockdevice dependency to KVstore library #14079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 21, 2020

Summary of changes

As KVstore relies on BlockDevice, add the dependency
in Mbed OS so applications do not have to specify it.

Needed by ARMmbed/mbed-os-example-kvstore#69

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


As KVstore relies on BlockDevice add the dependency
in Mbed OS so applications do not have to specify it
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 21, 2020
@ciarmcom ciarmcom requested review from a team December 21, 2020 14:30
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugueskamba hugueskamba requested a review from harmut01 December 21, 2020 19:35
@hugueskamba hugueskamba dismissed harmut01’s stale review December 21, 2020 19:44

Add comments instead of change requests and blocking PR if unsure

@mergify mergify bot added needs: CI and removed needs: work labels Dec 22, 2020
@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit e96b097 into ARMmbed:master Jan 4, 2021
@mergify mergify bot removed the ready for merge label Jan 4, 2021
@hugueskamba hugueskamba deleted the hk_cmake_kvstore_dependency branch January 4, 2021 11:08
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants