Skip to content

CMake: streamline kvstore support #14065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 17, 2020

Summary of changes

Link KVStore dependency in Mbed OS so application projects do not have to.

This PR is needed for ARMmbed/mbed-os-example-kvstore#69

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Link KVStore dependency in Mbed OS so application projects do not have to.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 17, 2020
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 17, 2020

I assume also kvstore example will be updated and linked here?

@hugueskamba
Copy link
Collaborator Author

I assume also kvstore example will be updated and linked here?

You can see it mentioned in the "Conversation" tab of this PR. That PR depends on this to be merged.

@mergify mergify bot added needs: CI and removed needs: review labels Dec 17, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2020

CI started

Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 569db57 into ARMmbed:master Dec 18, 2020
@mergify mergify bot removed the ready for merge label Dec 18, 2020
@hugueskamba hugueskamba deleted the hk_cmake_streamline_kvstore branch December 18, 2020 18:49
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants