Skip to content

CMake: Add support for Renesas targets #14021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2020
Merged

CMake: Add support for Renesas targets #14021

merged 3 commits into from
Dec 17, 2020

Conversation

harmut01
Copy link
Contributor

Summary of changes

As part of this PR, CMake configuration files were created to support 3 Renesas targets: GR_LYCHEE, GR_MANGO, and RZ_A1H. The interpreter used in the ARM scatter file was also modified from armcc to armclang. All targets build with GCC and ARM compilers, although, I was unable to test the binaries on hardware.

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @hugueskamba @rajkan01

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 10, 2020
@ciarmcom ciarmcom requested review from 0xc0170, hugueskamba, rajkan01 and a team December 10, 2020 10:30
@ciarmcom
Copy link
Member

@harmut01, thank you for your changes.
@hugueskamba @0xc0170 @rajkan01 @ARMmbed/team-renesas-rz @ARMmbed/mbed-os-maintainers please review.

@mergify
Copy link

mergify bot commented Dec 11, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@harmut01 harmut01 force-pushed the port_rz_targets branch 2 times, most recently from 7d43a5e to 5c9908b Compare December 11, 2020 09:10
@harmut01 harmut01 changed the title Port Renesas targets to CMake CMake: Port Renesas targets to CMake Dec 11, 2020
hugueskamba
hugueskamba previously requested changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@hugueskamba hugueskamba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the indentation and keep things in alphabetical order. I will review again once that is done.

@mergify mergify bot dismissed hugueskamba’s stale review December 11, 2020 11:59

Pull request has been modified.

hugueskamba
hugueskamba previously requested changes Dec 11, 2020
View reviewed changes
@hugueskamba hugueskamba changed the title CMake: Port Renesas targets to CMake CMake: Add support for Renesas targets Dec 11, 2020
@mergify mergify bot dismissed hugueskamba’s stale review December 11, 2020 15:05

Pull request has been modified.

hugueskamba
hugueskamba previously approved these changes Dec 11, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: work labels Dec 11, 2020
@mergify mergify bot dismissed hugueskamba’s stale review December 11, 2020 15:58

Pull request has been modified.

@harrisonmutai-arm
CMake: Port Renesas targets to CMake
e8614b3 
Add targets subdirectory to high level CMake configuration file and
create new configurations for MCUs and individual targets. Change the
interpreter in the ARM scatter file to armclang, which is required for
CMake. Remove private and public interfaces in emac target
configuration. Ensure that all targets build on the arm gcc compiler and
arm compiler.
@harrisonmutai-arm
CMake: Fix dirs and sources visibility for mbed-emac CMake target
b947ee3 
The mbed-emac CMake target is an interface library and as such its
include dirs and sources have to be have the INTERFACE visibility.
@harrisonmutai-arm
CMake: Add Renesas to list of supported targets
ddf2f01
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 14, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 626168a into ARMmbed:master Dec 17, 2020
@mergify mergify bot removed the ready for merge label Dec 17, 2020
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@hugueskamba hugueskamba hugueskamba approved these changes

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@harmut01 @ciarmcom @0xc0170 @mbed-ci @hugueskamba @mbedmain @harrisonmutai-arm