Skip to content

Nuvoton: Remove DISABLE/ENABLE macro definitions in BSP #14017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Dec 9, 2020

Summary of changes

Remove DISABLE/ENABLE macro definitions in BSP, which are not used on Mbed OS. This is to avoid name conflict with other modules.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

These are not used on Mbed OS. Remove them to avoid name conflict with other modules.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 9, 2020
@ciarmcom ciarmcom requested review from a team December 9, 2020 08:30
@ciarmcom
Copy link
Member

ciarmcom commented Dec 9, 2020

@ccli8, thank you for your changes.
@ARMmbed/team-nuvoton @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Dec 9, 2020
@mbed-ci
Copy link

mbed-ci commented Dec 9, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 336dd99 into ARMmbed:master Dec 9, 2020
@mergify mergify bot removed the ready for merge label Dec 9, 2020
@ccli8 ccli8 deleted the nuvoton_remove_enabledisable_macro branch December 10, 2020 01:24
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants