Skip to content

Clean-up: TDBStore no longer requires BlockDevice to have flash behaviour #14007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 17, 2020
Merged

Clean-up: TDBStore no longer requires BlockDevice to have flash behaviour #14007

merged 8 commits into from
Dec 17, 2020

Conversation

LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Dec 7, 2020 •
edited
Loading

Summary of changes

Since the merging of #11987, TDBStore works with any BlockDevice without requiring flash behaviour (i.e. erasing bytes to the erase value, FF). This PR

  • cleans up unnecessary wrapping of FlashSimBlockDevice throughout Mbed OS
  • updates any outdated design docs and Doxygen around flash simulation

Impact of changes

None.

Migration actions required

None.

Documentation

ARMmbed/mbed-os-5-docs#1386
(Not interdependent on this PR, but for the same goal)

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-core

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 7, 2020
@ciarmcom ciarmcom requested review from a team December 7, 2020 18:30
@ciarmcom
Copy link
Member

ciarmcom commented Dec 7, 2020

@LDong-Arm, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@mergify
Copy link

mergify bot commented Dec 9, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@LDong-Arm LDong-Arm force-pushed the tdb_no_flash_simulation branch from 4505e84 to 9a79c02 Compare December 10, 2020 10:03
@mergify
Copy link

mergify bot commented Dec 11, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

evedon
evedon previously approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@LDong-Arm LDong-Arm force-pushed the tdb_no_flash_simulation branch from 9a79c02 to b829645 Compare December 11, 2020 14:56
@LDong-Arm
Copy link
Contributor Author

Rebased

@mergify mergify bot dismissed evedon’s stale review December 11, 2020 14:57

Pull request has been modified.

@mergify mergify bot added needs: CI and removed needs: work labels Dec 14, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 16, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 46c9cf0 into ARMmbed:master Dec 17, 2020
@mergify mergify bot removed the ready for merge label Dec 17, 2020
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
@LDong-Arm LDong-Arm mentioned this pull request Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LDong-Arm @ciarmcom @0xc0170 @mbed-ci @evedon @mbedmain