Skip to content

Fix mbed::Dir type handling in fat_filesystem #13949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

Fix mbed::Dir type handling in fat_filesystem #13949

merged 1 commit into from
Nov 25, 2020

Conversation

LDong-Arm
Copy link
Contributor

Summary of changes

Fixes: #13836

Full credits to @kjbracey-arm for the fix.

Impact of changes

None.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@kjbracey-arm @ARMmbed/mbed-os-core @jamesbeyond

@LDong-Arm LDong-Arm mentioned this pull request Nov 23, 2020
Closed
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 23, 2020
@ciarmcom ciarmcom requested review from jamesbeyond, kjbracey and a team November 23, 2020 16:30
@ciarmcom
Copy link
Member

@LDong-Arm, thank you for your changes.
@jamesbeyond @kjbracey-arm @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

evedon
evedon previously approved these changes Nov 24, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Nov 24, 2020
0xc0170
0xc0170 previously approved these changes Nov 24, 2020
View reviewed changes
kjbracey
kjbracey previously requested changes Nov 24, 2020
View reviewed changes
@mergify mergify bot added needs: work and removed needs: CI labels Nov 24, 2020
jamesbeyond
jamesbeyond previously approved these changes Nov 24, 2020
View reviewed changes
@LDong-Arm @kjbracey
Fix mbed::Dir type handling in fat_filesystem
0491519 
Full credits to @kjbracey-arm for the fix.

Co-authored-by: Kevin Bracey <[email protected]>
@LDong-Arm LDong-Arm force-pushed the fat_filesystem_test_fix branch from f5e9909 to 0491519 Compare November 24, 2020 17:00
@LDong-Arm LDong-Arm requested a review from kjbracey November 24, 2020 17:00
@mergify mergify bot dismissed stale reviews from evedon, 0xc0170, kjbracey, and jamesbeyond November 24, 2020 17:01

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2020

As previously approved with small modification, I started CI.

@mbed-ci
Copy link

mbed-ci commented Nov 25, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@mergify mergify bot removed the needs: CI label Nov 25, 2020
@0xc0170 0xc0170 merged commit 66ca70a into ARMmbed:master Nov 25, 2020
@mergify mergify bot removed the ready for merge label Nov 25, 2020
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

@evedon evedon evedon left review comments

@jamesbeyond jamesbeyond jamesbeyond left review comments

Assignees
No one assigned
Labels
release-version: 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAT filesystem test failed to build after "PR #13549 Make readdir reentrant" merged
8 participants
@LDong-Arm @ciarmcom @0xc0170 @mbed-ci @kjbracey @evedon @jamesbeyond @mbedmain