Skip to content

Create a USB drivers library #13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 18, 2020
Merged

Create a USB drivers library #13869

merged 4 commits into from
Nov 18, 2020
+47 −46

Conversation

evedon
Copy link
Contributor

@evedon evedon commented Nov 5, 2020

Summary of changes

Create a USB drivers library under drivers/usb and follow the mbed-os component structure.

[component name]
├── mbed_lib.json
├── include               // The top-level include path
│   └── [component name]  // Public headers 
│       └── internal      // Internal headers
├── source                // Source files and private headers
└── tests
    └── TESTS                        
        └── <greentea test suite one> // Can be either source file or a directory

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 5, 2020
@ciarmcom ciarmcom requested review from a team November 5, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Nov 5, 2020

@evedon, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

LDong-Arm
LDong-Arm approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xc0170
0xc0170 reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, this will bring in CMake (usb component there will need to be updated).

+1 for creating own usb component in drivers

@mergify
Copy link

mergify bot commented Nov 11, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@evedon evedon force-pushed the cleanup-usb-drivers branch from 9d8c332 to 30e9050 Compare November 12, 2020 14:57
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Nov 12, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 12, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌

LDong-Arm
LDong-Arm approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CMakeLists.txt
@@ -114,7 +114,7 @@ add_subdirectory(events EXCLUDE_FROM_ALL)
add_subdirectory(connectivity EXCLUDE_FROM_ALL)
add_subdirectory(storage EXCLUDE_FROM_ALL)
add_subdirectory(drivers/device_key EXCLUDE_FROM_ALL)
add_subdirectory(drivers/source/usb EXCLUDE_FROM_ALL)
add_subdirectory(drivers/usb EXCLUDE_FROM_ALL)
Copy link
Contributor

@LDong-Arm LDong-Arm Nov 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR: for consistency with other libraries (e.g. connectivity, storage), add_subdirectory of device_key and usb should be done in drivers/CMakeLists.txt.

@evedon
Copy link
Contributor Author

evedon commented Nov 17, 2020

@adbridge Ready for CI

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 17, 2020

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Nov 18, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit c6094f7 into ARMmbed:master Nov 18, 2020
@mergify mergify bot removed the ready for merge label Nov 18, 2020
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Assignees
No one assigned
Labels
release-version: 6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evedon @ciarmcom @0xc0170 @mbed-ci @LDong-Arm @mbedmain