Skip to content

STM32L4: Use HSI for LPUART #13859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Conversation

jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Nov 4, 2020

Summary of changes

Using low power uart instance has some constraint about clock source selection.

See:
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/serial_api.c#L368

Default choice is LSE and PCLK1.

Issue was seen with DISCO_L475VG_IOT01A:

mbed test -t ARM -m DISCO_L475VG_IOT01A -v --app-config tests/configs/fpga.json -n hal-tests-tests-mbed_hal_fpga_ci_test_shield-uart -DFPGA_FORCE_ALL_PORTS

Tests with LPUART and 9600 baud rate are OK, not with 19200 (PCLK1 is 80MHz).

Impact of changes

Impact all STM32L4x5 and STM32L4x6 targets
For these targets, LPUART clack source is HSI (16 MHz)

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Impact all STM32L4x5 and STM32L4x6 targets
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 5, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2020

I'll restart CI (internal CI error)

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 10, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 added ready for merge release-type: patch Indentifies a PR as containing just a patch and removed needs: CI labels Nov 11, 2020
@0xc0170 0xc0170 merged commit a0e8ab9 into ARMmbed:master Nov 11, 2020
@mergify mergify bot removed the ready for merge label Nov 11, 2020
@jeromecoutant jeromecoutant deleted the PR_L4_LPUART_HSI branch November 12, 2020 07:50
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants