STM32 : full GPIO reset during mbed init #13777

jeromecoutant · 2020-10-16T15:11:45Z

Summary of changes

This fixes #11853
This reset all GPIO during boot, before application start.
This will allow better power consumption in deepsleep mode.

Issue was seen on NUCLEO-L152RE,
but we propose to apply this GPIO reset for all STM32.

@ARMmbed/team-st-mcd
@star297

Impact of changes

Migration actions required

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

ciarmcom · 2020-10-16T15:30:36Z

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

targets/TARGET_STM/mbed_overrides.c

jeromecoutant · 2020-11-03T07:54:09Z

Let's start CI ?
Thx

0xc0170 · 2020-11-03T11:25:22Z

CI started

mbed-ci · 2020-11-03T16:00:16Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️
jenkins-ci/mbed-os-ci_greentea-test	❌

jeromecoutant · 2020-11-04T15:49:46Z

Could you restart CI ?

0xc0170 · 2020-11-12T12:08:30Z

CI started

mbed-ci · 2020-11-12T22:33:54Z

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	❌
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	❌

jeromecoutant · 2020-11-25T07:41:49Z

Hi
Could you restart CI ?
Tests are OK on my side...

Pull request has been modified.

0xc0170 · 2020-11-30T16:24:53Z

CI restarted

mbed-ci · 2020-11-30T22:42:28Z

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	❌
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	❌
jenkins-ci/mbed-os-ci_greentea-test	❌

0xc0170 · 2020-12-03T11:26:19Z

I'll restart CI once we get CI green again

0xc0170 · 2020-12-07T11:15:44Z

CI restarted

mbed-ci · 2020-12-07T16:51:39Z

Jenkins CI Test : ❌ FAILED

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️
jenkins-ci/mbed-os-ci_greentea-test	❌

mbed-ci · 2020-12-08T17:33:54Z

Jenkins CI Test : ❌ FAILED

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	❌

mbed-ci · 2020-12-08T18:31:12Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️

0xc0170 · 2020-12-09T05:54:58Z

dynamic-memory-usage can be ignored as it was disabled and did not rerun. I'll merge now.

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 16, 2020

ciarmcom requested a review from a team October 16, 2020 15:30

ciarmcom added the needs: review label Oct 16, 2020

LMESTM suggested changes Oct 16, 2020

View reviewed changes

targets/TARGET_STM/mbed_overrides.c Show resolved Hide resolved

mergify bot added needs: work and removed needs: review labels Oct 16, 2020

jeromecoutant force-pushed the PR_L152 branch from 3fc77df to f09ad37 Compare October 19, 2020 13:08

LMESTM approved these changes Oct 19, 2020

View reviewed changes

0xc0170 previously approved these changes Nov 3, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: work labels Nov 3, 2020

0xc0170 added needs: work and removed needs: CI labels Nov 3, 2020

0xc0170 added needs: CI and removed needs: work labels Nov 12, 2020

mergify bot added needs: work and removed needs: CI labels Nov 12, 2020

STM32: full GPIO reset during mbed init

59fc99b

jeromecoutant force-pushed the PR_L152 branch from f09ad37 to 59fc99b Compare November 25, 2020 08:08

0xc0170 added needs: CI and removed needs: work labels Nov 30, 2020

mergify bot added needs: work and removed needs: CI labels Nov 30, 2020

0xc0170 added needs: CI and removed needs: work labels Dec 3, 2020

mergify bot added needs: work and removed needs: CI labels Dec 8, 2020

0xc0170 added ready for merge and removed needs: work labels Dec 9, 2020

0xc0170 merged commit e2777c2 into ARMmbed:master Dec 9, 2020

mergify bot removed the ready for merge label Dec 9, 2020

jeromecoutant deleted the PR_L152 branch December 9, 2020 08:24

jeromecoutant mentioned this pull request Dec 11, 2020

STM32: RESET GPIO during init is configurable #14032

Merged

mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020

kjansen-adi mentioned this pull request Jan 11, 2021

[Mbed OS 6.6.0] Flashing SDP-K1 board causes interface firmware to fail. Can no longer program board after flashing with any Mbed OS 6.6.0 project. #14121

Closed

STM32 : full GPIO reset during mbed init #13777

STM32 : full GPIO reset during mbed init #13777

Uh oh!

Conversation

jeromecoutant commented Oct 16, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Oct 16, 2020

Uh oh!

Uh oh!

jeromecoutant commented Nov 3, 2020

Uh oh!

0xc0170 commented Nov 3, 2020

Uh oh!

mbed-ci commented Nov 3, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

jeromecoutant commented Nov 4, 2020

Uh oh!

0xc0170 commented Nov 12, 2020

Uh oh!

mbed-ci commented Nov 12, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

jeromecoutant commented Nov 25, 2020

Uh oh!

0xc0170 commented Nov 30, 2020

Uh oh!

mbed-ci commented Nov 30, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Dec 3, 2020

Uh oh!

0xc0170 commented Dec 7, 2020

Uh oh!

mbed-ci commented Dec 7, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

mbed-ci commented Dec 8, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

mbed-ci commented Dec 8, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Dec 9, 2020

Uh oh!

Uh oh!