Skip to content

Add missing args to weakly defined PalRtc functions #13749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Oct 13, 2020
Merged

Add missing args to weakly defined PalRtc functions #13749

merged 1 commit into from Oct 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2020

Summary of changes

This fixes lto type mismatch warnings in 3 functions

[Warning] pal_rtc.h@76,6: type of 'PalRtcCompareSet' does not match original declaration [-Wlto-type-mismatch]
[Warning] pal_rtc.h@73,6: type of 'PalRtcEnableCompareIrq' does not match original declaration [-Wlto-type-mismatch]
[Warning] pal_rtc.h@74,6: type of 'PalRtcDisableCompareIrq' does not match original declaration [-Wlto-type-mismatch]

Closes: #13644

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 10, 2020
@ciarmcom
Copy link
Member

@jrobeson, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team October 10, 2020 02:30
@0xc0170 0xc0170 requested a review from a team October 12, 2020 06:56
@paul-szczepanek-arm
Copy link
Member

Thanks, could you please revert the accidental style changes? Makes the diff unreadable.

@ghost
Copy link
Author

ghost commented Oct 12, 2020

oh, sorry. I didn't realize my vim was still set up that way! i will take care of that.

This fixes lto type mismatch warnings in 3 functions
e27571f 
```sh
[Warning] pal_rtc.h@76,6: type of 'PalRtcCompareSet' does not match original declaration [-Wlto-type-mismatch]
[Warning] pal_rtc.h@73,6: type of 'PalRtcEnableCompareIrq' does not match original declaration [-Wlto-type-mismatch]
[Warning] pal_rtc.h@74,6: type of 'PalRtcDisableCompareIrq' does not match original declaration [-Wlto-type-mismatch]
```
@ghost
Copy link
Author

ghost commented Oct 12, 2020

done

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Oct 13, 2020
@mbed-ci
Copy link

mbed-ci commented Oct 13, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 4c42952 into ARMmbed:master Oct 13, 2020
@mergify mergify bot removed the ready for merge label Oct 13, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning LTO type mismatch in pal_rtc.h
5 participants
@ciarmcom @paul-szczepanek-arm @0xc0170 @mbed-ci @mbedmain