Skip to content

Add crash RAM to STM32F412xG #13723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 16, 2020

Conversation

boraozgen
Copy link
Contributor

@boraozgen boraozgen commented Oct 6, 2020

Summary of changes

Added crash RAM to STM32F412xG. Copied the same parts from STM32F411xE. The linker script is now identical to STM32F411xE. Tested on custom board with STM32F412CG.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested a review from a team October 6, 2020 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Oct 6, 2020

@boraozgen, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@boraozgen
Copy link
Contributor Author

@jeromecoutant

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to align ARM and IAR files ?
Thx

@boraozgen
Copy link
Contributor Author

@jeromecoutant

The IAR linker script is considerably different from the F411RE, therefore I cannot just copy the related part. Besides I do not use the Mbed Studio therefore I cannot test it on the ARM compiler. Can you/someone else deal with this? Should be simple for someone who knows the IAR syntax.

@jeromecoutant
Copy link
Collaborator

The IAR linker script is considerably different from the F411RE, therefore I cannot just copy the related part.

IAR is no more mandatory in MBED. So align GCC and ARMC6 linker scripts, and I will be OK :-)

@mergify mergify bot added the needs: work label Oct 9, 2020
@mergify
Copy link

mergify bot commented Oct 9, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot removed the needs: review label Oct 9, 2020
@boraozgen
Copy link
Contributor Author

I applied the differences in F411RE ARMC script to F412xG. It looks simple and should not cause problems, but as I said I cannot test it as I do not use ARMC.

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my branch:
https://github.com/jeromecoutant/mbed/tree/REVIEW_13723
for full alignment between both families

Test platform-tests-tests-mbed_platform-crash_reporting
OK with NUCLEO_F412ZG and NUCLEO_F411RE for GCC, ARMC6, and IAR

Thx

@adbridge
Copy link
Contributor

This is target specific so should be a patch rather than a feature - will fix

@adbridge adbridge added release-type: patch Indentifies a PR as containing just a patch and removed release-type: feature labels Oct 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

CI restarted, internal error

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 2d01a44 into ARMmbed:master Oct 16, 2020
@mergify mergify bot removed the ready for merge label Oct 16, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants