-
Notifications
You must be signed in to change notification settings - Fork 3k
Add crash RAM to STM32F412xG #13723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crash RAM to STM32F412xG #13723
Conversation
@boraozgen, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to align ARM and IAR files ?
Thx
The IAR linker script is considerably different from the F411RE, therefore I cannot just copy the related part. Besides I do not use the Mbed Studio therefore I cannot test it on the ARM compiler. Can you/someone else deal with this? Should be simple for someone who knows the IAR syntax. |
IAR is no more mandatory in MBED. So align GCC and ARMC6 linker scripts, and I will be OK :-) |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
I applied the differences in F411RE ARMC script to F412xG. It looks simple and should not cause problems, but as I said I cannot test it as I do not use ARMC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my branch:
https://github.com/jeromecoutant/mbed/tree/REVIEW_13723
for full alignment between both families
Test platform-tests-tests-mbed_platform-crash_reporting
OK with NUCLEO_F412ZG and NUCLEO_F411RE for GCC, ARMC6, and IAR
Thx
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TOOLCHAIN_ARM/stm32f412xg.sct
Outdated
Show resolved
Hide resolved
Review 13723
This is target specific so should be a patch rather than a feature - will fix |
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
CI restarted, internal error |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Added crash RAM to STM32F412xG. Copied the same parts from STM32F411xE. The linker script is now identical to STM32F411xE. Tested on custom board with STM32F412CG.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers