Skip to content

STM32_gen_PeripheralPins.py v1.17 #13655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2020
Merged

STM32_gen_PeripheralPins.py v1.17 #13655

merged 2 commits into from
Oct 16, 2020

Conversation

jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Sep 22, 2020 •
edited
Loading

Summary of changes

Hi

It's a long time I did not sync my personal script with the one in mbed repo.

Many updated lines:

  • Octo SPI support
  • bug correction
  • warning style correction
  • new TIM_MST choice algo
  • full PinNames.h file creation
  • output directory is now
    targets_custom/TARGET_STM/TARGET_STM32XX/TARGET_STM32XXXX

[edit] add correction in GPIO xml files parsing
Fix #13711

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify bot added the needs: work label Sep 22, 2020
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 22, 2020
@ciarmcom ciarmcom requested a review from a team September 22, 2020 14:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team September 22, 2020 14:30
@ladislas
Copy link
Contributor

Can't wait to try it out!

Can you explain the "new TIM_MST choice algo"?

@jeromecoutant
Copy link
Collaborator Author

jeromecoutant commented Sep 22, 2020 •
edited
Loading

Can you explain the "new TIM_MST choice algo"?

In PWM pinmap table, we comment lines using TIM_MST, timer used for USTICKER.
This "arbitrary" choice algo has been changed to try to find an existing timer for all STM32.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 23, 2020

@jeromecoutant just having this in the tools , not used by cli/online compiler? Asking due to tools being frozen - I'll request additional approval to get this in.

@jeromecoutant
Copy link
Collaborator Author

@jeromecoutant just having this in the tools , not used by cli/online compiler? Asking due to tools being frozen - I'll request additional approval to get this in.

Not used at all, it's a manual script.
I can move it in targets/target_ST/ if needed

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 23, 2020

@ARMmbed/mbed-os-tools Shall the script be moved to targets folder rather than being in tools ? Please review

@jeromecoutant
Copy link
Collaborator Author

@ARMmbed/mbed-os-tools Shall the script be moved to targets folder rather than being in tools ? Please review

@ARMmbed/mbed-os-tools Thx

@jeromecoutant jeromecoutant mentioned this pull request Oct 5, 2020
Closed
@jeromecoutant
STM32_gen_PeripheralPins.py v1.17
2d25882 
- GPIO xml parsing correction (ARMmbed#13711)
- Octo SPI support
- bug correction
- warning style correction
- new TIM_MST choice algo
- full PinNames.h file creation
- output directory is now
    targets_custom/TARGET_STM/TARGET_STM32XX/TARGET_STM32XXXX
@jeromecoutant jeromecoutant mentioned this pull request Oct 5, 2020
Closed
@rwalton-arm
Copy link
Contributor

@ARMmbed/mbed-os-tools Shall the script be moved to targets folder rather than being in tools ? Please review

Yes, I agree that we should move this script to the targets folder. It's not part of the general tools and only works with ST targets, so it makes sense for it to be in the targets folder.

@jeromecoutant
Copy link
Collaborator Author

Yes, I agree that we should move this script to the targets folder. It's not part of the general tools and only works with ST targets, so it makes sense for it to be in the targets folder.

Done

0xc0170
0xc0170 reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it makes sense to follow the tools folder so the scripts like this that are target specific could be shared there. rather than in the targets/TARGET_ root?

@jeromecoutant
Copy link
Collaborator Author

@0xc0170 you could start CI

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@mergify mergify bot removed the needs: CI label Oct 15, 2020
@0xc0170 0xc0170 merged commit aa0cd63 into ARMmbed:master Oct 16, 2020
@mergify mergify bot removed the ready for merge label Oct 16, 2020
@jeromecoutant jeromecoutant deleted the PR_GENPERIPH_1_17 branch October 16, 2020 09:18
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STM32_gen_PeripheralPins.py takes wrong GPIO file
7 participants
@jeromecoutant @ciarmcom @ladislas @0xc0170 @rwalton-arm @mbed-ci @mbedmain