Skip to content

Nordic: Support 31250 baud rate #13595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

gutbag
Copy link

@gutbag gutbag commented Sep 10, 2020

Summary of changes

Add support for MIDI baud rate 31250 on Nordic nRF52 targets. Fixes #13577

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Tested by setting BufferSerial baud rates to 28800, 31250 & 38840 and checking that receiver sees all characters correctly at each setting.


Reviewers


@gutbag gutbag marked this pull request as ready for review September 10, 2020 16:43
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 10, 2020
@ciarmcom ciarmcom requested a review from a team September 10, 2020 17:00
@ciarmcom
Copy link
Member

@gutbag, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Sep 14, 2020
@0xc0170 0xc0170 changed the title Support 31250 baud rate Nordic: Support 31250 baud rate Sep 15, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 15, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest
jenkins-ci/mbed-os-ci_greentea-test ✔️

@mergify mergify bot added needs: work and removed needs: CI labels Sep 15, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 15, 2020

Known issue, we are working on fixing it (internal CI issue).

cc @ARMmbed/mbed-os-test

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit c8345a3 into ARMmbed:master Oct 16, 2020
@mergify mergify bot removed the ready for merge label Oct 16, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nRF52 does not support baud rate 31250 for MIDI
5 participants