Skip to content

Nuvoton: Fixed NUC472 SD buffer alignment #13547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

cyliangtw
Copy link
Contributor

@cyliangtw cyliangtw commented Sep 4, 2020

Summary of changes

This PR is to correct NUC472 SD buffer alignment. According to NUC472 SD H/W spec, to change the alignment as 4 bytes instead of original 4KB, it could avoid the most wasting of PAD of SD buffer. It could avoid this kind issue Pelion PR #147 .

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 4, 2020
@ciarmcom ciarmcom requested a review from a team September 4, 2020 09:00
@ciarmcom
Copy link
Member

ciarmcom commented Sep 4, 2020

@cyliangtw, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 7, 2020

Travis failed with connectivity issue, I restarted it.

@mergify mergify bot added needs: CI and removed needs: review labels Sep 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 8, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 8, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 0190014 into ARMmbed:master Sep 9, 2020
@mergify mergify bot removed the ready for merge label Sep 9, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
@cyliangtw cyliangtw deleted the nvt_nuc472_sd branch December 6, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants