Skip to content

Targets: Add default "supported_form_factors" for all targets #13502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2020
Merged

Targets: Add default "supported_form_factors" for all targets #13502

merged 1 commit into from
Aug 28, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

This helps mbed-tools to build targets that do not set that
attribute themselves.

Fixes: ARMmbed/mbed-tools#70

Impact of changes

Migration actions required

Documentation

Pull request type

  • Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
  • Feature update (New feature / Functionality change / New API)
  • Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

  • No Tests required for this change (E.g docs only update)
  • Covered by existing mbed-os tests (Greentea or Unittest)
  • Tests / results supplied as part of this PR

Reviewers

@hugueskamba
Targets: Add default "supported_form_factors" for all targets
1e5cdaf 
This helps mbed-tools to build targets that do not set that
attribute themselves.
@ciarmcom ciarmcom requested a review from a team August 27, 2020 14:30
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@hugueskamba hugueskamba mentioned this pull request Aug 27, 2020
Merged
6 tasks
Patater
Patater approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: review labels Aug 27, 2020
@hugueskamba
Copy link
Collaborator Author

CI Started!

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@evedon evedon added the release-type: patch Indentifies a PR as containing just a patch label Aug 28, 2020
@evedon evedon merged commit 297300e into ARMmbed:master Aug 28, 2020
@mergify mergify bot removed the ready for merge label Aug 28, 2020
@hugueskamba hugueskamba deleted the hk_add_default_form_factor branch August 28, 2020 12:13
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@evedon evedon evedon approved these changes

@rwalton-arm rwalton-arm Awaiting requested review from rwalton-arm

Assignees
No one assigned
Labels
release-version: 6.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to create .mbedbuild/mbed_config.cmake for WIO_3G target
6 participants
@hugueskamba @ciarmcom @mbed-ci @Patater @evedon @mbedmain