-
Notifications
You must be signed in to change notification settings - Fork 3k
KVSTORE tests: move directories #13484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeromecoutant, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add also a reason for this move to the commit message?
I would even rename the directory where main.cpp test is, to shorter as it has all prefix device_key_...
same as the parent, not needed , just tbd
enough in that case? same for the whitebox prefix in the second test.
@jeromecoutant, thank you for your changes. |
OK Before PR: With this PR: New proposition? |
This allows compilation in Windows environment with name length constraint
9924535
to
ff76c01
Compare
done |
ping |
CI started This however just avoids the main issue ,but hopefully soon we got CMake and components and response files to battle the length. @ARMmbed/mbed-os-core please review |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Thanks @jeromecoutant we'll watch for the test name length. |
@jeromecoutant Hi, I wonder if your mbed-os repo is checked out in a directory that's already deep? It's said that Windows has a path length limit of 256 characters, whereas the test even before renaming had only 112 characters. Maybe the installation path/home directory of git bash is already quite deep? (This can be even deeper for WSL.) In this case the directories above mbed-os might already take quite some characters? |
Summary of changes
I am working with Windows environment and git bash.
Got build issues with kvstore tests and test name length
Impact of changes
None, same test but with a more simple name
Migration actions required
Documentation
Pull request type
Test results
Reviewers