Skip to content

KVSTORE tests: move directories #13484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

I am working with Windows environment and git bash.
Got build issues with kvstore tests and test name length

Impact of changes

None, same test but with a more simple name

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 24, 2020
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team August 24, 2020 13:00
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add also a reason for this move to the commit message?

I would even rename the directory where main.cpp test is, to shorter as it has all prefix device_key_... same as the parent, not needed , just tbd enough in that case? same for the whitebox prefix in the second test.

@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team August 24, 2020 15:30
@jeromecoutant
Copy link
Collaborator Author

I would even rename the directory where main.cpp test is, to shorter as it has all prefix device_key_... same as the parent, not needed , just tbd enough in that case? same for the whitebox prefix in the second test.

OK

Before PR:
storage/kvstore/direct_access_devicekey/tests/TESTS/direct_access_devicekey/direct_access_devicekey_tdb/main.cpp
storage/kvstore/securestore/tests/TESTS/securestore/securestore_whitebox/main.cpp

With this PR:
storage/kvstore/tests/TESTS/direct_access_devicekey/direct_access_devicekey_tdb/main.cpp
storage/kvstore/tests/TESTS/securestore/securestore_whitebox/main.cpp

New proposition?
storage/kvstore/tests/TESTS/direct_access_devicekey/tdb/main.cpp
storage/kvstore/tests/TESTS/securestore/whitebox/main.cpp

This allows compilation in Windows environment with name length constraint
@jeromecoutant
Copy link
Collaborator Author

Can you add also a reason for this move to the commit message?

done

@jeromecoutant
Copy link
Collaborator Author

ping

@mergify mergify bot added needs: CI and removed needs: review labels Sep 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 7, 2020

CI started

This however just avoids the main issue ,but hopefully soon we got CMake and components and response files to battle the length.

@ARMmbed/mbed-os-core please review

@0xc0170 0xc0170 requested a review from a team September 7, 2020 15:33
@mbed-ci
Copy link

mbed-ci commented Sep 7, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@evedon
Copy link
Contributor

evedon commented Sep 8, 2020

Thanks @jeromecoutant we'll watch for the test name length.

@LDong-Arm
Copy link
Contributor

LDong-Arm commented Sep 8, 2020

@jeromecoutant Hi, I wonder if your mbed-os repo is checked out in a directory that's already deep? It's said that Windows has a path length limit of 256 characters, whereas the test even before renaming had only 112 characters.

Maybe the installation path/home directory of git bash is already quite deep? (This can be even deeper for WSL.) In this case the directories above mbed-os might already take quite some characters?

@0xc0170 0xc0170 merged commit bb618d0 into ARMmbed:master Sep 9, 2020
@mergify mergify bot removed the ready for merge label Sep 9, 2020
@jeromecoutant jeromecoutant deleted the PR_KVSTORE_TESTS branch September 9, 2020 11:43
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants