Skip to content

Add ccache to travis #13468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2020
Merged

Add ccache to travis #13468

merged 1 commit into from
Aug 24, 2020

Conversation

urutva
Copy link
Contributor

@urutva urutva commented Aug 20, 2020

Summary of changes

Add ccache to travis

Based on the changes in #13435

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 20, 2020
@ciarmcom ciarmcom requested review from a team August 20, 2020 12:00
@ciarmcom
Copy link
Member

@urutva, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

jainvikas8
jainvikas8 previously approved these changes Aug 20, 2020
View reviewed changes
@Patater
Copy link
Contributor

Patater commented Aug 20, 2020

I'd recommend turning on ccache in .travis.yml as well.

@urutva
Copy link
Contributor Author

urutva commented Aug 20, 2020

I'd recommend turning on ccache in .travis.yml as well.

Ccache is configured by default in Travis, but there is no support for arm-none-eabi- yet. The command in tools/test/travis-ci/functions.sh are executed as part of travis install step

mbed-os/.travis.yml

Line 218 in dc693a9

- source_pkg gcc
. There is no need to additionally enable Ccache in Travis.

@urutva urutva force-pushed the add-ccache-to-travis branch from dc693a9 to 5756079 Compare August 20, 2020 13:11
@mergify mergify bot dismissed jainvikas8’s stale review August 20, 2020 13:12

Pull request has been modified.

Patater
Patater reviewed Aug 20, 2020
View reviewed changes
tools/test/travis-ci/functions.sh Outdated
pushd /usr/lib/ccache
sudo ln -s ../../bin/ccache arm-none-eabi-gcc
sudo ln -s ../../bin/ccache arm-none-eabi-g++
export PATH="$PATH:/usr/lib/ccache"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use export PATH="/usr/lib/ccache:$PATH" to ensure ccache links are used (PATH lookup is first listed first used).

@urutva urutva force-pushed the add-ccache-to-travis branch 6 times, most recently from d8ca7ac to 0c8f46b Compare August 20, 2020 16:15
Patater
Patater previously approved these changes Aug 20, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Aug 20, 2020
0xc0170
0xc0170 previously approved these changes Aug 21, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@urutva urutva changed the title Add ccache to travis DO_NOT_MERGE: Add ccache to travis Aug 21, 2020
@urutva urutva force-pushed the add-ccache-to-travis branch from 0c8f46b to 165226c Compare August 21, 2020 09:53
@mergify mergify bot dismissed Patater’s stale review August 21, 2020 09:53

Pull request has been modified.

@mergify mergify bot dismissed 0xc0170’s stale review August 21, 2020 09:53

Pull request has been modified.

@urutva urutva force-pushed the add-ccache-to-travis branch from 165226c to ed1e897 Compare August 21, 2020 12:50
@mergify mergify bot added the needs: work label Aug 21, 2020
@mergify
Copy link

mergify bot commented Aug 21, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@urutva urutva force-pushed the add-ccache-to-travis branch 2 times, most recently from d894b2d to c7eabaa Compare August 21, 2020 12:56
@urutva
ci: Enable ccache in Travis
fef4454 
Signed-off-by: Devaraj Ranganna <[email protected]>
@urutva urutva force-pushed the add-ccache-to-travis branch from c7eabaa to fef4454 Compare August 21, 2020 13:22
@urutva urutva changed the title DO_NOT_MERGE: Add ccache to travis Add ccache to travis Aug 21, 2020
@mergify mergify bot added needs: CI and removed needs: work labels Aug 21, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 08ef04d into ARMmbed:master Aug 24, 2020
@mergify mergify bot removed the ready for merge label Aug 24, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

@jainvikas8 jainvikas8 jainvikas8 left review comments

Assignees
No one assigned
Labels
release-version: 6.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@urutva @ciarmcom @Patater @0xc0170 @mbed-ci @jainvikas8 @mbedmain