-
Notifications
You must be signed in to change notification settings - Fork 3k
Refactor storage COMPONENT_xx directory #13445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor storage COMPONENT_xx directory #13445
Conversation
For example, in BLE we have |
Yes, I agree that will be more readable, but directory restructures confluence page suggested like 'component name' is same as 'include/[component name]' so I just followed the similar fashion as 'include/COMPONENT_xx'
@evedon Could you confirm, which one to follow either Lingkai suggested directory name like include/DataFlash or include/COMPONENT_DATAFLASH |
This is the final version when the new build system is in place. For now magic words (e.g. COMPONENT_xx) are needed but should appear in as few places as possible while things still work, in my opinion. |
I have made header include header directory more readable as suggested, please re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
@0xc0170 Could you review and start the CI |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@0xc0170 CI passed for this PR, please merge |
We will merge as soon as 6.2.1 is released (later today). |
Summary of changes
Restructured
storage/blockdevice/COMPONENT_xx
as per the new directory structure proposal:Impact of changes
None.
Migration actions required
None.
Documentation
To Be Updated.
Pull request type
Test results
Manual testing: (Build for K64F target with GCC_ARM toolchain)
Reviewers
@0xc0170 @ARMmbed/mbed-os-core