Skip to content

Move Callback tests to platform, USB tests to drivers #13434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

LDong-Arm
Copy link
Contributor

Summary of changes

When refactoring platform and drivers directories, we missed a couple of Greentea test groups. The PR moves the following:

  • TESTS/mbed_functional/ -> platform/tests/TESTS/mbed_functional/: tests platform/Callback.h
  • TESTS/usb_device/ -> drivers/tests/TESTS/usb_device/: tests drivers/USB*.h

Impact of changes

None.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-core


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 14, 2020
@ciarmcom
Copy link
Member

@LDong-Arm, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team August 14, 2020 17:30
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 17, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Aug 17, 2020
@mbed-ci
Copy link

mbed-ci commented Aug 17, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 207a164 into ARMmbed:master Aug 21, 2020
@mergify mergify bot removed the ready for merge label Aug 21, 2020
@jeromecoutant
Copy link
Collaborator

Hi
Did you verify USB tests...?

[1598357855.58][HTST][ERR] host test not detected: pyusb_basic
[1598357867.94][HTST][ERR] host test not detected: usb_device_serial
[1598357879.91][HTST][ERR] host test not detected: usb_device_hid
[1598357892.70][HTST][ERR] host test not detected: pyusb_msd

@jeromecoutant
Copy link
Collaborator

Did you verify USB tests...?

See #13501

@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants