-
Notifications
You must be signed in to change notification settings - Fork 3k
Refactor NFC directory structure #13414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@donatieng I didn't break down @ARMmbed/mbed-os-connectivity Any idea about NFC test app? Has anyone run it recently? I haven't been able to run it yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current changes LGTM. Still, the connectivity team has to approve as some changes on the proposed directory structure in a confluence page
@LDong-Arm, thank you for your changes. |
@donatieng has had a look at the revised directory structure (in the PR description) and agrees with the idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll help @paul-szczepanek-arm get time for a coffee. This LGTM. Thanks @LDong-Arm!
@rajkan01 @donatieng Thanks for the reviews! |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
New NFC directory structure:
Note: Unlike previously discussed, I have put
acore
andstack
inlibraries
because they are both self-contained "sub" libraries, used by the main NFC code and target drivers. Keeping their existing internal structures makes more sense than trying to split them into include & source which is rather intrusive.NOTE: This PR does NOT cover NFC in TEST_APPS - it hasn't been updated or used for a while, maybe the Connectivity team should take it over and decide what to do?
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Manual testing
mbed test -t ARM -m NUCLEO_F401RE --compile -n connectivity-nfc-tests-tests-nfc-eeprom
Reviewers
@donatieng @paul-szczepanek-arm @ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-core