Provide enablement of nrf52840 SPIM #13397

winneymj · 2020-08-07T00:02:29Z

Summary of changes

Currently SPIM code exists in TARGET_SDK_15 for the nrf52840 but is not available to execute in Mbed.

These changes allow the developer to enable SPIM through the configuration file:
mbed-os\targets\TARGET_NORDIC\TARGET_NRF5x\TARGET_NRF52\TARGET_MCU_NRF52840\config\sdk_config.h

Enable the NRFX_SPIM_ENABLED, and because SPI and SPIM use the same hardware, disable the NRFX_SPI_ENABLED

Impact of changes

Migration actions required

Documentation

None that I can see. Would be nice to find a section where I could mention SPIM enabling.

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

This reverts commit dec6e36.

ciarmcom · 2020-08-07T01:00:33Z

@winneymj, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-hal please review.

0xc0170

We are not changing default behavior as it is now (I do not see changes in sdk_config file), it is NRFX_SPI_ENABLED, is that correct?

What is the reason for adding SPIM?

winneymj · 2020-08-10T13:04:48Z

The reason I want SPIM is that the regular SPI on nrf52 chips is limited to 8Mhz. SPIM (instance 3) can go upto 32Mhz. This is really nice when using an SPI display to get a fast refresh rate. You can see the extra SPIM frequencies at the https://github.com/winneymj/mbed-os/blob/5249a9ad31806dfd42a934dbc369ed40d1ff2bcc/targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/spi_api.c#L440 I left the sdk_config.h file alone and defaulted to NFRX_SPI_ENABLED. Did not want to switch this on unless someone really needed it. I have enabled the NFRX_SPIM_ENABLED on my other branches to make sure it works. The SPI master implements EasyDMA for reading and writing of data packets from and to the DATA RAM without CPU involvement. More information on nrf52 SPIM can be found here: https://infocenter.nordicsemi.com/index.jsp?topic=%2Fcom.nordic.infocenter.nrf52832.ps.v1.1%2Fspim.html&cp=2_1_0_30&anchor=concept_j35_hv2_wr Thanks Mark

…

On Mon, Aug 10, 2020 at 4:14 AM Martin Kojtal ***@***.***> wrote: ***@***.**** commented on this pull request. We are not changing default behavior as it is now (I do not see changes in sdk_config file), it is NRFX_SPI_ENABLED, is that correct? What is the reason for adding SPIM? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13397 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABK26BHZ6322ZASHRXY4H2DR763ABANCNFSM4PXCYQLQ> .

winneymj · 2020-08-10T13:06:44Z

Hi, After reading email again I just wanted to let you know that I am not adding SPIM to mbed, it already exists...I am just allowing it be compiled and executed by enabling the feature in the sdk_config.h Thanks Mark

…

On Mon, Aug 10, 2020 at 8:04 AM Mark Winney ***@***.***> wrote: The reason I want SPIM is that the regular SPI on nrf52 chips is limited to 8Mhz. SPIM (instance 3) can go upto 32Mhz. This is really nice when using an SPI display to get a fast refresh rate. You can see the extra SPIM frequencies at the https://github.com/winneymj/mbed-os/blob/5249a9ad31806dfd42a934dbc369ed40d1ff2bcc/targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/spi_api.c#L440 I left the sdk_config.h file alone and defaulted to NFRX_SPI_ENABLED. Did not want to switch this on unless someone really needed it. I have enabled the NFRX_SPIM_ENABLED on my other branches to make sure it works. The SPI master implements EasyDMA for reading and writing of data packets from and to the DATA RAM without CPU involvement. More information on nrf52 SPIM can be found here: https://infocenter.nordicsemi.com/index.jsp?topic=%2Fcom.nordic.infocenter.nrf52832.ps.v1.1%2Fspim.html&cp=2_1_0_30&anchor=concept_j35_hv2_wr Thanks Mark On Mon, Aug 10, 2020 at 4:14 AM Martin Kojtal ***@***.***> wrote: > ***@***.**** commented on this pull request. > > We are not changing default behavior as it is now (I do not see changes > in sdk_config file), it is NRFX_SPI_ENABLED, is that correct? > > What is the reason for adding SPIM? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#13397 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABK26BHZ6322ZASHRXY4H2DR763ABANCNFSM4PXCYQLQ> > . >

0xc0170 · 2020-08-11T12:57:05Z

Ci started

mbed-ci · 2020-08-11T13:21:06Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	❌
jenkins-ci/mbed-os-ci_build-GCC_ARM	❌

0xc0170 · 2020-08-11T13:24:26Z

Please review build logs, there are build errors:

[Error] objects.h@100,5: unknown type name 'nrfx_spi_config_t'
[ERROR] In file included from ./mbed-os/connectivity/FEATURE_BLE/libraries/TARGET_CORDIO/source/PalGenericAccessServiceImpl.cpp:19:
In file included from ./mbed-os/connectivity/FEATURE_BLE/include/ble/internal/PalGenericAccessService.h:25:
In file included from ./mbed-os/connectivity/FEATURE_BLE/include/ble/Gap.h:26:
In file included from ./mbed-os/drivers/include/drivers/LowPowerTimeout.h:20:
In file included from ./mbed-os/platform/include/platform/platform.h:28:
In file included from ./mbed-os/targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52832/TARGET_NRF52_DK/device.h:36:
./mbed-os/targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/objects.h:100:5: error: unknown type name 'nrfx_spi_config_t'
    nrfx_spi_config_t config;
    ^

Pull request has been modified.

0xc0170 · 2020-08-17T07:20:35Z

CI started

mbed-ci · 2020-08-17T07:56:55Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️

0xc0170 · 2020-08-19T12:49:40Z

CI started

mbed-ci · 2020-08-19T13:31:05Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️

boraozgen · 2021-07-01T08:04:04Z

Just for the record, the commits should have been squashed before merging. The line-by-line git history is messed up with these commits.

boraozgen · 2021-07-01T08:06:22Z

Furthermore, SPI::transfer API does not seem to work properly with SPIM. I couldn't diagnose the reason yet, but I believe it has something to do with the driver reinitializing before every transfer.

mjwinney added 18 commits July 15, 2020 16:15

Initial commit

dec6e36

Fix missing pins

24624d2

Add missing softdevice common

8526148

Add USBConsole.h so that default printf can be sent to USBSerial

4c299fe

Move SPI_PSELSSO = p41

65ed9d4

Enable SPIM and bring into code.

db23d53

Fix include

bcacf21

Enable nrfx_spim_1_irq_handler

c6bc651

Fix more SPIM

2d5776a

Add Int handler for SPIM3_IRQHandler

f65cd0f

Mix SPI with SPIM

b6a1ec7

First stab at implement SPIM DCX

e4e7dcc

more dcx

77d6787

Revert "Initial commit"

32b5f2d

This reverts commit dec6e36.

Disable SPIM & enable SPI

0b80e3c

remove NRFX_SPIM_NRF52_ANOMALY_109_WORKAROUND_ENABLED

40831f7

Remove DEBUG

541a2c8

Remove duplicate code

5249a9a

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 7, 2020

ciarmcom requested review from a team August 7, 2020 01:00

ciarmcom added the needs: review label Aug 7, 2020

0xc0170 reviewed Aug 10, 2020

View reviewed changes

0xc0170 previously approved these changes Aug 11, 2020

View reviewed changes

mergify bot added needs: work and removed needs: review needs: CI labels Aug 11, 2020

Fix detection of enabled SPIM

6dbeece

mjwinney added 2 commits August 15, 2020 08:02

Fix detection of enabled SPIM

21c928e

Fix defines

b72adbe

0xc0170 added needs: CI and removed needs: work labels Aug 17, 2020

Add SPIM description to README.md

e5f32ff

0xc0170 approved these changes Aug 21, 2020

View reviewed changes

0xc0170 removed request for a team August 21, 2020 09:39

0xc0170 added ready for merge and removed needs: CI labels Aug 21, 2020

0xc0170 merged commit d44fb29 into ARMmbed:master Aug 21, 2020

mergify bot removed the ready for merge label Aug 21, 2020

winneymj deleted the enable_SPIM branch September 5, 2020 21:52

mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Provide enablement of nrf52840 SPIM #13397

Provide enablement of nrf52840 SPIM #13397

Uh oh!

winneymj commented Aug 7, 2020

Uh oh!

ciarmcom commented Aug 7, 2020

Uh oh!

0xc0170 left a comment

Uh oh!

winneymj commented Aug 10, 2020 via email •

edited

Loading

Uh oh!

winneymj commented Aug 10, 2020 via email •

edited

Loading

Uh oh!

0xc0170 commented Aug 11, 2020

Uh oh!

mbed-ci commented Aug 11, 2020

Uh oh!

0xc0170 commented Aug 11, 2020

Uh oh!

0xc0170 commented Aug 17, 2020

Uh oh!

mbed-ci commented Aug 17, 2020

Uh oh!

0xc0170 commented Aug 19, 2020

Uh oh!

mbed-ci commented Aug 19, 2020

Uh oh!

boraozgen commented Jul 1, 2021

Uh oh!

boraozgen commented Jul 1, 2021

Uh oh!

Uh oh!

Provide enablement of nrf52840 SPIM #13397

Provide enablement of nrf52840 SPIM #13397

Uh oh!

Conversation

winneymj commented Aug 7, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Aug 7, 2020

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

winneymj commented Aug 10, 2020 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

winneymj commented Aug 10, 2020 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Aug 11, 2020

Uh oh!

mbed-ci commented Aug 11, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Aug 11, 2020

Uh oh!

0xc0170 commented Aug 17, 2020

Uh oh!

mbed-ci commented Aug 17, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Aug 19, 2020

Uh oh!

mbed-ci commented Aug 19, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

boraozgen commented Jul 1, 2021

Uh oh!

boraozgen commented Jul 1, 2021

Uh oh!

Uh oh!

winneymj commented Aug 10, 2020 via email •

edited

Loading

winneymj commented Aug 10, 2020 via email •

edited

Loading