Add GR_MANGO as a new target #13375

RyoheiHagimoto · 2020-07-30T01:37:47Z

Summary of changes

Adding GR-MANGO as a new target.

Impact of changes

none

Migration actions required

none

Documentation

none.
GR_MANGO is added to the targets.
Added NULL-check to dns_get_interface_server() function in lwip_dns.c.

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

greentea_grmango_20200729.zip

UDP test was failed because of network environment.
rtos-tests-tests-mbedmicro-rtos-mbed-basic was ERROR because of issue #13359.

Reviewers

ciarmcom · 2020-07-30T03:00:30Z

@RyoheiHagimoto, thank you for your changes.
@toyowata @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-ipcore please review.

targets/TARGET_RENESAS/TARGET_RZ_A2XX/TARGET_GR_MANGO/device.h

0xc0170 · 2020-07-30T09:30:13Z

Please review astyle failures

RyoheiHagimoto · 2020-07-31T12:01:08Z

Could you re-review this request?
Modified files to fix following 2 issues:

align with astyle rule.
delete old ARMC5 check.

greentea_grmango_20200731.zip

Pull request has been modified.

RyoheiHagimoto · 2020-08-03T03:13:54Z

Modified features/netsocket/emac_drivers/TARGET_RENESAS_EMAC/TARGET_RZ_A1XXX files to follow astyle.

greentea_rza1h_20200803.zip

mergify · 2020-08-05T10:57:13Z

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Pull request has been modified.

RyoheiHagimoto · 2020-08-06T21:36:58Z

Rebased the repository.
Could you re-review?

greentea_grmango_gccarm_20200806.zip

toyowata · 2020-08-07T03:01:24Z

@RyoheiHagimoto
Your PR contains some merge commits.
https://github.com/ARMmbed/mbed-os/pull/13375/commits

Can you fix?

0xc0170 · 2020-08-12T20:03:35Z

@RyoheiHagimoto can you rebase to clean the history on your branch?

Added argument-check to avoid accessing NULL pointer. The second argument 'interface_name' of this function can be NULL. And the argument 'interface_name' is used for the argument of strcmp() without checked. For example, LWIP::add_dns_server() calls dns_getserver(index - 1, NULL).

0xc0170 · 2020-08-19T12:49:15Z

CI started

mbed-ci · 2020-08-19T13:29:43Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	❌
jenkins-ci/mbed-os-ci_build-GCC_ARM	❌

0xc0170 · 2020-08-19T13:41:01Z

Please review the build failures, they are related

toyowata · 2020-08-20T01:04:28Z

@0xc0170 I have quickly checked the log file. The target name for --mcu option should be GR_MANGO, not RZ_A2XX.

python -u ../mbed-os/tools/test/examples/examples.py -e mbed-os-example-blinky compile ARM --mcu RZ_A2XX

Compiling example repos....

[EXAMPLES]> INFO     In folder 'mbed-os-example-blinky'
[EXAMPLES]> INFO     Compiling mbed-os-example-blinky RZ_A2XX ARM
[EXAMPLES]> INFO     Executing command 'mbed-cli compile -t ARM -m RZ_A2XX -j 0'...

#### STDOUT ####
Building project mbed-os-example-blinky (RZ_A2XX, ARMC6)
Scan: mbed-os-example-blinky
Configuration error: Bootloader not supported on this target. ROM start not found in targets.json.
Configuration error: Bootloader not supported on this target. RAM start not found in targets.json.
No Linker Script found

Could not compile for RZ_A2XX: No Linker Script found```

0xc0170 · 2020-08-20T07:32:20Z

targets/targets.json

+        "core": "Cortex-A9",
+        "supported_toolchains": ["ARM", "GCC_ARM", "IAR"],
+        "extra_labels": ["RENESAS", "RZ_A2XX"],
+        "device_has": [


the issue is here, the target should not be a public (it's MCU_).

0xc0170 · 2020-08-20T07:32:51Z

@toyowata +1, I've found the issue in the targets,json, I left a comment above

toyowata · 2020-08-20T08:14:48Z

@0xc0170 thanks for your comment.

the issue is here, the target should not be a public (it's MCU_).

Do you mean the inherited target RZ_A2XX should have below?

    "public": false,

0xc0170 · 2020-08-20T10:23:10Z

Yes that is correct

Pull request has been modified.

toyowata

@RyoheiHagimoto thank you for the change.
@0xc0170 can you please start CI?

0xc0170 · 2020-08-21T09:33:32Z

CI restarted

mbed-ci · 2020-08-21T10:49:39Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️

mergify bot added the needs: work label Jul 30, 2020

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 30, 2020

ciarmcom requested review from toyowata and a team July 30, 2020 03:00

ciarmcom added the needs: review label Jul 30, 2020

toyowata reviewed Jul 30, 2020

View reviewed changes

targets/TARGET_RENESAS/TARGET_RZ_A2XX/TARGET_GR_MANGO/device.h Outdated Show resolved Hide resolved

0xc0170 removed the needs: review label Jul 30, 2020

0xc0170 previously approved these changes Jul 31, 2020

View reviewed changes

toyowata self-requested a review July 31, 2020 14:34

toyowata previously approved these changes Jul 31, 2020

View reviewed changes

toyowata previously approved these changes Aug 4, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: work labels Aug 4, 2020

mergify bot added needs: work and removed needs: CI labels Aug 5, 2020

RyoheiHagimoto force-pushed the add_gr-mango branch from f665d57 to c16d890 Compare August 18, 2020 01:38

mergify bot added needs: CI and removed needs: work labels Aug 18, 2020

mergify bot added needs: work and removed needs: CI labels Aug 19, 2020

0xc0170 previously requested changes Aug 20, 2020

View reviewed changes

Added public token for RZ_A2XX in target.json

c854392

toyowata self-requested a review August 20, 2020 14:12

toyowata approved these changes Aug 20, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: work labels Aug 20, 2020

mergify bot added ready for merge and removed needs: CI labels Aug 21, 2020

0xc0170 merged commit 7b211f0 into ARMmbed:master Aug 21, 2020

mergify bot removed the ready for merge label Aug 21, 2020

RyoheiHagimoto deleted the add_gr-mango branch August 27, 2020 01:56

mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020

Add GR_MANGO as a new target #13375

Add GR_MANGO as a new target #13375

Uh oh!

Conversation

RyoheiHagimoto commented Jul 30, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Jul 30, 2020

Uh oh!

Uh oh!

0xc0170 commented Jul 30, 2020

Uh oh!

RyoheiHagimoto commented Jul 31, 2020

Uh oh!

RyoheiHagimoto commented Aug 3, 2020

Uh oh!

mergify bot commented Aug 5, 2020

Uh oh!

RyoheiHagimoto commented Aug 6, 2020

Uh oh!

toyowata commented Aug 7, 2020

Uh oh!

0xc0170 commented Aug 12, 2020

Uh oh!

0xc0170 commented Aug 19, 2020

Uh oh!

mbed-ci commented Aug 19, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Aug 19, 2020

Uh oh!

toyowata commented Aug 20, 2020

Uh oh!

0xc0170 Aug 20, 2020

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Aug 20, 2020

Uh oh!

toyowata commented Aug 20, 2020

Uh oh!

0xc0170 commented Aug 20, 2020

Uh oh!

toyowata left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Aug 21, 2020

Uh oh!

mbed-ci commented Aug 21, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

Uh oh!