Skip to content

travis: Reject changes to tools #13349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Jul 24, 2020

Summary of changes

As part of freezing the current Mbed tools, reject any changes to tools that would require a re-release of the tools for the online compiler. This enables us to focus our effort on developing a far more maintainable set of tools, rather than on performing existing tool releases which are very error prone, time consuming, and labor intensive.

No new releases of the online tools are planned. To keep feature parity between the offline and online tools (i.e. to keep the online compiler working), we are locking the Mbed OS tools.

Impact of changes

None

Migration actions required

None

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers

@jamesbeyond @rwalton-arm


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 24, 2020
@ciarmcom
Copy link
Member

@Patater, thank you for your changes.
@rwalton-arm @jamesbeyond @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from jamesbeyond, rwalton-arm and a team July 24, 2020 15:00
@mergify mergify bot removed the needs: review label Jul 27, 2020
@Patater Patater force-pushed the reject-tool-changes branch 13 times, most recently from d6e3a12 to ca0db95 Compare July 28, 2020 11:30
@Patater Patater changed the title WIP: travis: Reject changes to tools travis: Reject changes to tools Jul 28, 2020
@Patater
Copy link
Contributor Author

Patater commented Jul 28, 2020

rwalton-arm
rwalton-arm previously approved these changes Jul 28, 2020
@mergify mergify bot added needs: CI and removed needs: work labels Jul 28, 2020
jamesbeyond
jamesbeyond previously approved these changes Jul 28, 2020
@mergify mergify bot dismissed stale reviews from rwalton-arm and jamesbeyond August 4, 2020 16:33

Pull request has been modified.

@Patater
Copy link
Contributor Author

Patater commented Aug 4, 2020

Add a bad commit to test Travis CI error message.

@mergify mergify bot added needs: work and removed needs: CI labels Aug 4, 2020
@Patater
Copy link
Contributor Author

Patater commented Aug 4, 2020

Bad Travis CI run for test purposes: https://travis-ci.org/ARMmbed/mbed-os/jobs/714917860

Failure: Frozen files were modified
tools/toolchains/gcc.py
Please see https://os.mbed.com/blog/entry/Introducing-the-new-Mbed-Tools/ 
for why we've frozen the legacy tools.

@Patater
Copy link
Contributor Author

Patater commented Aug 4, 2020

Removed bad commit.

@mergify mergify bot removed the needs: review label Aug 5, 2020
@adbridge
Copy link
Contributor

adbridge commented Aug 7, 2020

CI started

@0xc0170 0xc0170 merged commit ead1cec into ARMmbed:master Aug 11, 2020
@mergify mergify bot removed the ready for merge label Aug 11, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants