Skip to content

Adding NUCLEO_F429ZI to AWS example #13326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Adding NUCLEO_F429ZI to AWS example #13326

merged 1 commit into from
Jul 22, 2020

Conversation

ashok-rao
Copy link
Contributor

@ashok-rao ashok-rao commented Jul 21, 2020 •
edited
Loading

Summary of changes

Adding NUCLEO_F429ZI to the list of supported targets for AWS example's CI.

Impact of changes

-None-

Migration actions required

-None-

Documentation

-None-

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Test results attached below:
Nucleo_F429zi_log.txt

Reviewers

@evedon @LDong-Arm @jamesbeyond

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 21, 2020
@ciarmcom ciarmcom requested review from evedon, jamesbeyond, LDong-Arm and a team July 21, 2020 15:00
@ciarmcom
Copy link
Member

@ashok-rao, thank you for your changes.
@evedon @jamesbeyond @LDong-Arm @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

LDong-Arm
LDong-Arm approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: review labels Jul 21, 2020
@evedon
Copy link
Contributor

evedon commented Jul 21, 2020

@ashok-rao I don't think there is documentation to update for this PR.

@ashok-rao
Copy link
Contributor Author

@ashok-rao I don't think there is documentation to update for this PR.

You are correct @evedon . PR description now edited. Thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 22, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 65bc057 into ARMmbed:master Jul 22, 2020
@mergify mergify bot removed the ready for merge label Jul 22, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

@jamesbeyond jamesbeyond Awaiting requested review from jamesbeyond

Assignees
No one assigned
Labels
release-version: 6.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ashok-rao @ciarmcom @evedon @0xc0170 @mbed-ci @LDong-Arm @mbedmain