Skip to content

Updating targets.json file for SDP-K1 board. #13320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

Updating targets.json file for SDP-K1 board. #13320

merged 1 commit into from
Jul 28, 2020

Conversation

malavikasajikumar
Copy link
Contributor

@malavikasajikumar malavikasajikumar commented Jul 21, 2020 •
edited
Loading

Summary of changes

Removing ANALOGOUT, RTC and SERIAL_FC from SDP-K1 description.
Adding TRNG to the description.
Updated the clock source description.

Impact of changes

N/A

Migration actions required

N/A

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

SDP_K1_GCC_ARM_test_modified.log

Reviewers

@malavikasajikumar malavikasajikumar mentioned this pull request Jul 21, 2020
Closed
@mergify mergify bot added the needs: work label Jul 21, 2020
@ciarmcom ciarmcom requested a review from a team July 21, 2020 05:00
@ciarmcom
Copy link
Member

@malavikasajikumar, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously requested changes Jul 21, 2020
View reviewed changes
targets/targets.json Outdated
"MPU"
],
"device_has_remove": ["LPTICKER"],
"device_has_remove": [
"LPTICKER",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please align these lines, same as MPU above (just 4 spaces to right)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+it's using tabs instead of spaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Fixed now. @0xc0170 @kjbracey-arm

@mergify mergify bot dismissed 0xc0170’s stale review July 21, 2020 19:39

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 22, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@adbridge
Copy link
Contributor

Approved by @andypowers

@adbridge adbridge merged commit 93ee6da into ARMmbed:mbed-os-5.15 Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@malavikasajikumar @ciarmcom @0xc0170 @mbed-ci @adbridge @kjbracey